Re: Difficulty adding a symbolic link, part 3

2013-08-01 Thread Dale R. Worley
From: Duy Nguyen pclo...@gmail.com With the above change, the test suite runs with zero failures, so it doesn't affect any common Git usage. It means the test suite is incomplete. As you can see, the commit introducing this change does not come with a test case to catch people changing

Re: Difficulty adding a symbolic link, part 3

2013-08-01 Thread Dale R. Worley
From: Duy Nguyen pclo...@gmail.com Can someone give me advice on what this code *should* do? It does as the function name says: given cwd, a prefix (i.e. a relative path with no .. components) and a path relative to cwd+prefix, convert 'path' to something relative to cwd. In the simplest

Re: Difficulty adding a symbolic link, part 3

2013-08-01 Thread Duy Nguyen
On Thu, Aug 1, 2013 at 10:00 PM, Dale R. Worley wor...@alum.mit.edu wrote: From: Duy Nguyen pclo...@gmail.com Can someone give me advice on what this code *should* do? It does as the function name says: given cwd, a prefix (i.e. a relative path with no .. components) and a path relative to

Difficulty adding a symbolic link, part 3

2013-07-31 Thread Dale R. Worley
I've run into a problem (with Git 1.8.3.3) where I cannot add a symbolic link (as such) to the repository *if* its path is given absolutely; instead Git adds the file the symbolic link points to. (If I give the path relatively, Git does what I expect, that is, adds the symbolic link.) I've

Re: Difficulty adding a symbolic link, part 3

2013-07-31 Thread Duy Nguyen
On Thu, Aug 1, 2013 at 3:29 AM, Dale R. Worley wor...@alum.mit.edu wrote: I've run into a problem (with Git 1.8.3.3) where I cannot add a symbolic link (as such) to the repository *if* its path is given absolutely; instead Git adds the file the symbolic link points to. (If I give the path