Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-10 Thread Duy Nguyen
On Fri, May 9, 2014 at 12:04 PM, David Kastrup wrote: > Jeff King writes: > >> I'd actually be inclined to say the opposite of what Junio is saying >> there: that "-b" should blank the author field as well as the commit >> sha1. I'd even go so far as to say that "-b" should probably be the >> def

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-10 Thread David Kastrup
Junio C Hamano writes: > Jeff King writes: > >> On Fri, May 09, 2014 at 07:04:05AM +0200, David Kastrup wrote: >> >>> Arguably if the user explicitly limited the range, he knows what he's >>> looking at. Admittedly, I don't know offhand which options _will_ >>> produce boundary commit indication

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-09 Thread Junio C Hamano
Jeff King writes: > On Fri, May 09, 2014 at 07:04:05AM +0200, David Kastrup wrote: > >> Arguably if the user explicitly limited the range, he knows what he's >> looking at. Admittedly, I don't know offhand which options _will_ >> produce boundary commit indications: there may be some without expl

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-09 Thread Jeff King
On Fri, May 09, 2014 at 07:04:05AM +0200, David Kastrup wrote: > Arguably if the user explicitly limited the range, he knows what he's > looking at. Admittedly, I don't know offhand which options _will_ > produce boundary commit indications: there may be some without explicit > range limitation, a

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-09 Thread David Kastrup
Jeff King writes: > I'd actually be inclined to say the opposite of what Junio is saying > there: that "-b" should blank the author field as well as the commit > sha1. I'd even go so far as to say that "-b" should probably be the > default when boundary commits are in use. I cannot think of a tim

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Jeff King
On Thu, May 08, 2014 at 02:56:46PM -0700, Junio C Hamano wrote: > In short: > > - I am not considering nor proposing to change the default at all. > > - I have two choices, either change the behaviour of "-b", or >introducing a new option (the latter includes "-b -b"); I am >slightly i

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Jeff King
On Thu, May 08, 2014 at 11:32:01PM +0200, David Kastrup wrote: > Jeff King writes: > > > On Thu, May 08, 2014 at 01:52:38PM -0700, Junio C Hamano wrote: > > > >> ( 103) > >> 7bbc458b (Kyle J. McKay 2014-04-22 04:16:22 -0700 104) test_exp

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Junio C Hamano
John Keeping writes: > Yes, it's marking it as a boundary but I'm not convinced that's correct. > Compare these two cases: > > $ git blame Makefile | head -5 > 7a3fc144 (John Keeping 2013-12-26 17:37:53 + 1) REL_VERSION = v0.2 > 5c9829f9 (John Keeping 2013-07-29 17:03:26 +0100 2

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread John Keeping
On Thu, May 08, 2014 at 11:10:24PM +0100, John Keeping wrote: > On Thu, May 08, 2014 at 02:58:58PM -0700, Junio C Hamano wrote: > > John Keeping writes: > > > > > On a slight tangent, I tried this in a fairly young repository and got > > > this (with master at v2.0.0-rc2-4-g1dc51c6): > > > > > >

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread John Keeping
On Thu, May 08, 2014 at 02:58:58PM -0700, Junio C Hamano wrote: > John Keeping writes: > > > On a slight tangent, I tried this in a fairly young repository and got > > this (with master at v2.0.0-rc2-4-g1dc51c6): > > > > $ git blame Makefile | head -5 > > 7a3fc144 (John Keeping 2013-12-26 17

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Junio C Hamano
John Keeping writes: > On a slight tangent, I tried this in a fairly young repository and got > this (with master at v2.0.0-rc2-4-g1dc51c6): > > $ git blame Makefile | head -5 > 7a3fc144 (John Keeping 2013-12-26 17:37:53 + 1) REL_VERSION = v0.2 > 5c9829f9 (John Keeping 2013-07-29

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Junio C Hamano
In short: - I am not considering nor proposing to change the default at all. - I have two choices, either change the behaviour of "-b", or introducing a new option (the latter includes "-b -b"); I am slightly in favor of the latter, but not by a large margin. - I have two choices, regar

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread John Keeping
On Thu, May 08, 2014 at 01:52:38PM -0700, Junio C Hamano wrote: > I am tempted to say "blame that is run without the --porcelain > option is a end-user facing Porcelain, and people should not be > reading its output in their scripts" and change the behaviour of the > "-b" option to instead show som

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread David Kastrup
Jeff King writes: > On Thu, May 08, 2014 at 01:52:38PM -0700, Junio C Hamano wrote: > >> ( 103) >> 7bbc458b (Kyle J. McKay 2014-04-22 04:16:22 -0700 104) test_expect_... >> ( 105)

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Jeff King
On Thu, May 08, 2014 at 01:52:38PM -0700, Junio C Hamano wrote: > ( 103) > 7bbc458b (Kyle J. McKay 2014-04-22 04:16:22 -0700 104) test_expect_... > ( 105) test... > 7bbc458b

Re: Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread David Kastrup
Junio C Hamano writes: > If you run > > $ git blame -L103,107 v2.0.0-rc0..v2.0.0-rc2 t/t9117-git-svn-init-clone.sh > > you will see something like this: > > ^cc29195 (Junio C Hamano 2014-04-18 11:21:43 -0700 103) > 7bbc458b (Kyle J. McKay 2014-04-22 04:16:22 -0700 104) test_expect_.

Output from "git blame A..B -- path" for the bottom commit is misleading

2014-05-08 Thread Junio C Hamano
If you run $ git blame -L103,107 v2.0.0-rc0..v2.0.0-rc2 t/t9117-git-svn-init-clone.sh you will see something like this: ^cc29195 (Junio C Hamano 2014-04-18 11:21:43 -0700 103) 7bbc458b (Kyle J. McKay 2014-04-22 04:16:22 -0700 104) test_expect_... ^cc29195 (Junio C Hamano 2014-0