Re: [PATCH] submodule: Respect reqested branch on all clones

2014-01-04 Thread Heiko Voigt
Hi, On Fri, Jan 03, 2014 at 10:06:11AM -0800, W. Trevor King wrote: From: W. Trevor King wk...@tremily.us The previous code only checked out the requested branch in cmd_add. This commit moves the branch-checkout logic into module_clone, where it can be shared by cmd_add and cmd_update. I

Re: [PATCH] submodule: Respect reqested branch on all clones

2014-01-04 Thread W. Trevor King
On Sat, Jan 04, 2014 at 11:09:15PM +0100, Heiko Voigt wrote: On Fri, Jan 03, 2014 at 10:06:11AM -0800, W. Trevor King wrote: @@ -306,7 +307,14 @@ module_clone() echo gitdir: $rel/$a $sm_path/.git rel=$(echo $a | sed -e 's|[^/][^/]*|..|g') - (clear_local_git_env; cd $sm_path

Re: Re: [PATCH] submodule: Respect reqested branch on all clones

2014-01-04 Thread Heiko Voigt
On Sat, Jan 04, 2014 at 02:54:01PM -0800, W. Trevor King wrote: On Sat, Jan 04, 2014 at 11:09:15PM +0100, Heiko Voigt wrote: On Fri, Jan 03, 2014 at 10:06:11AM -0800, W. Trevor King wrote: @@ -306,7 +307,14 @@ module_clone() echo gitdir: $rel/$a $sm_path/.git rel=$(echo $a |

Re: [PATCH] submodule: Respect reqested branch on all clones

2014-01-04 Thread W. Trevor King
On Sun, Jan 05, 2014 at 01:39:22AM +0100, Heiko Voigt wrote: On Sat, Jan 04, 2014 at 02:54:01PM -0800, W. Trevor King wrote: On Sat, Jan 04, 2014 at 11:09:15PM +0100, Heiko Voigt wrote: On Fri, Jan 03, 2014 at 10:06:11AM -0800, W. Trevor King wrote: @@ -861,7 +860,12 @@ Maybe you want to

Re: [PATCH] submodule: Respect reqested branch on all clones

2014-01-04 Thread Francesco Pretto
Thanks for adding your contribute. My comments below: 2014/1/3 W. Trevor King wk...@tremily.us: The previous code only checked out the requested branch in cmd_add. This commit moves the branch-checkout logic into module_clone, where it can be shared by cmd_add and cmd_update. I also update