git-diff(1) appears to contradict itself

2013-02-11 Thread Reuben Thomas
Under the --color=when option, it says: Show colored diff. The value must be always (the default for when), never, or auto. The default value is never. That seems to imply that the default is both always and never. If I'm right, I suggest removing the parenthesis, and putting the correct default

Re: git-diff(1) appears to contradict itself

2013-02-11 Thread Junio C Hamano
Reuben Thomas r...@sc3d.org writes: Under the --color=when option, it says: Show colored diff. The value must be always (the default for when), never, or auto. The default value is never. I think it wants to say this: You can say diff --color without saying when. That is the same

Re: git-diff(1) appears to contradict itself

2013-02-11 Thread Reuben Thomas
On 12 February 2013 02:54, Junio C Hamano gits...@pobox.com wrote: Reuben Thomas r...@sc3d.org writes: Under the --color=when option, it says: Show colored diff. The value must be always (the default for when), never, or auto. The default value is never. I think it wants to say this: