Re: [git-users] [BUG] TABs in documentation

2019-01-27 Thread Philip Oakley

Hi Dan,

Sounds highly plausible.

I think the fix would be to send a simple patch upstream to change the 
tabs to 8 spaces (because of the poor HTML formatting in some browsers).


It's fairly easy. 'Just' download and install the SDK (the Contribute 
button), subscribe to the g...@vger.kernel.org list (via the 'majordomo' 
manager), and then send a patch via the send-email facility (which 
bypasses the 'No HTML'/ 'Plain text only' issue for most folks). Usually 
requires a couple of iterations for minor issues, but it's not too 
painful, and wins Kudos points ;-)


Philip

On 27/01/2019 12:21, Dan Alexandru wrote:
I’m not sure where to report this, but in git version 2.20.1.windows.1 
there’s a problem with the non-printable characters of the 
documentation files.


For example, running `git merge-base --help` opens 
file:///C:/Program%20Files/Git/mingw64/share/doc/git-doc/git-merge-base.html 
which includes ASCII 0x09 TAB characters in the history graphs, which 
are rendered misleadingly in my Chromium-based browser (but fine in 
Firefox).


Specifically, here’s how the last tabs-and-spaces-preformatted graph 
at the bottom of that page looks to me:


vivaldi-pre-offline.png

which wrongly suggests that the rebase point of the previous command 
was B^ instead of the actual B (due to the TABs being rendered 
narrower than the SPACEs).


Interestingly, the corresponding online page 
https://git-scm.com/docs/git-merge-base renders fine (like in Firefox):


vivaldi-pre-online.png

perhaps due to some fonts substitutions.

I think that this whole problem would be avoided if the 0x09 TAB 
characters from the documentation were replaced with 0x20 SPACE 
characters.


--
You received this message because you are subscribed to the Google 
Groups "Git for human beings" group.
To unsubscribe from this group and stop receiving emails from it, send 
an email to git-users+unsubscr...@googlegroups.com 
.

For more options, visit https://groups.google.com/d/optout.


--
You received this message because you are subscribed to the Google Groups "Git for 
human beings" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to git-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


[git-users] [BUG] TABs in documentation

2019-01-27 Thread Dan Alexandru
I’m not sure where to report this, but in git version 2.20.1.windows.1 
there’s a problem with the non-printable characters of the documentation 
files.

For example, running `git merge-base --help` opens 
file:///C:/Program%20Files/Git/mingw64/share/doc/git-doc/git-merge-base.html 
which includes ASCII 0x09 TAB characters in the history graphs, which are 
rendered misleadingly in my Chromium-based browser (but fine in Firefox).

Specifically, here’s how the last tabs-and-spaces-preformatted graph at the 
bottom of that page looks to me:

[image: vivaldi-pre-offline.png]
which wrongly suggests that the rebase point of the previous command was B^ 
instead of the actual B (due to the TABs being rendered narrower than the 
SPACEs).

Interestingly, the corresponding online page 
https://git-scm.com/docs/git-merge-base renders fine (like in Firefox):

[image: vivaldi-pre-online.png]
perhaps due to some fonts substitutions.

I think that this whole problem would be avoided if the 0x09 TAB characters 
from the documentation were replaced with 0x20 SPACE characters.

-- 
You received this message because you are subscribed to the Google Groups "Git 
for human beings" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to git-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.