Re: [PATCH v2 00/21] Support multiple worktrees

2013-12-22 Thread Duy Nguyen
On Sun, Dec 22, 2013 at 1:38 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >>> I am not happy with the choice of "main/HEAD" that would squat on a >>> good name for remote-tracking branch (i.e. s/origin/main/), though. >>> $GIT_DIR/COMMON_HEAD perhaps? >> >> It's not just about HEAD. Anything

Re: [PATCH v4 01/23] sha1write: make buffer const-correct

2013-12-22 Thread Christian Couder
On Sat, Dec 21, 2013 at 2:59 PM, Jeff King wrote: > We are passed a "void *" and write it out without ever s/are passed/pass/ Cheers, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

Re: [PATCH] do not pretend sha1write returns errors

2013-12-22 Thread Thomas Rast
Jeff King writes: > The sha1write function returns an int, but it will always be > "0". The failure-prone parts of the function happen in the > "flush" callback, which cannot pass an error back to us. So > we just end up calling die() during the flush. > > Let's just drop the return value altoget

Re: questions / suggestions about history simplification

2013-12-22 Thread Adam Spiers
On Sat, Dec 21, 2013 at 10:44:43PM -0800, Junio C Hamano wrote: > Adam Spiers writes: > > >> I doubt it. 75% of the work for such a person to understand the > >> behaviour from such an example is to understand what kind of history > >> the example is building. > > > > Agreed. And that's precise

Rationale behind 'extern' on protypes in .h files

2013-12-22 Thread Ravi Shekhar Jethani
Hi, I am a C & Data Structure teacher at at an institute. Up until now I have only written classroom type C code. I always had interest in operating systems especially Linux Kernel but never got into anything just passively followed 'lwn.net', 'dr dobbs magazine' etc. But the series '30 Linux Kern

Re: Rationale behind 'extern' on protypes in .h files

2013-12-22 Thread Stefan Beller
On 22.12.2013 16:51, Ravi Shekhar Jethani wrote: > > Now, my real question : > 1) I cannot understand the reason behind making function prototypes as > extern. What purpose does this serve? AFAIK we put definition in a .c > file and the prototype in a .h thats it. > > 2) Why are some prototypes

Re: Rationale behind 'extern' on protypes in .h files

2013-12-22 Thread Jed Brown
Stefan Beller writes: > From my understanding there is no > difference for functions declarations being set to extern or not, > because extern is the default on functions. There is a difference for shared libraries if you would like to control which symbols are exported. With gcc, for example, y

[PATCH] [RFC] Making use of bitmaps for thin objects

2013-12-22 Thread Ben Maurer
I've been hacking with the performance of git on a large, quickly changing git repo used inside Facebook. Pulling a week of changes from this repo can be quite painful. $ { echo HEAD && echo ^$have; } | time git pack-objects --no-use-bitmap-index --revs --stdout >/dev/null Counting objects: 2210

RE: [PATCH] [RFC] Making use of bitmaps for thin objects

2013-12-22 Thread Ben Maurer
One issue with this approach is that it seems git-pack-index doesn't perform as well with thin packs. git-index-pack uses a multi-threaded approach to resolving the deltas. However, the multithreading only works on deltas that are exclusively in the pack. After the multi-threaded phase, it incre

Re: [PATCH 4/5] safe_create_leading_directories(): fix a mkdir/rmdir race

2013-12-22 Thread Ramsay Jones
On 22/12/13 07:14, Michael Haggerty wrote: > It could be that some other process is trying to clean up empty > directories at the same time that safe_create_leading_directories() is > attempting to create them. In this case, it could happen that > directory "a/b" was present at the end of one iter

Re: [PATCH/POC 3/7] setup.c: add split-repo support to .git files

2013-12-22 Thread Duy Nguyen
On Sat, Dec 14, 2013 at 3:43 AM, Jonathan Nieder wrote: > Problems: > > * What if I move my worktree with "mv"? Then I still need the >corresponding $GIT_SUPER_DIR/repos/ directory, and nobody told >the GIT_SUPER_DIR about it. > > * What if my worktree is on removable media (think "netw