[PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-17 Thread Aleksey Mokhovikov
and concatenating them the into one template string. Signed-off-by: Aleksey Mokhovikov moxobu...@gmail.com --- branch.c | 39 --- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/branch.c b/branch.c index 723a36b..2ee353f 100644 --- a/branch.c

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-18 Thread Aleksey Mokhovikov
This patch replaces if chain that selects the message with 2 dimensional array of format strings and arguments. Signed-off-by: Aleksey Mokhovikov moxobu...@gmail.com --- This patch is unrelated with previous one, but related to GSoC. So I don't know if I should create new thread for this patch

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-18 Thread Aleksey Mokhovikov
Eric Sunshine sunshine at sunshineco.com writes: The subject should be concise. Try to keep it at 65-70 characters or less. More detailed information can be written following the subject (separated from the subject by a blank line). Write in imperative tone: say replace X with Y rather than

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-18 Thread Aleksey Mokhovikov
This patch replaces if chain with 2 dimensional array of format strings and arguments. Signed-off-by: Aleksey Mokhovikov moxobu...@gmail.com --- This patch is unrelated with previous one, but related to GSoC. So I don't know if I should create new thread for this patch. Compare with original

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-18 Thread Aleksey Mokhovikov
Matthieu Moy Matthieu.Moy at grenoble-inp.fr writes: Hi, Aleksey Mokhovikov moxobukob at gmail.com writes: Please, read the threads for other submissions for this microproject. Most remarks done there also apply for your case. See for example: http://thread.gmane.org/gmane.comp.version

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-20 Thread Aleksey Mokhovikov
On 03/19/2014 04:21 PM, Eric Sunshine wrote: Thanks for the resubmission. Comments below... On Tue, Mar 18, 2014 at 10:33 AM, Aleksey Mokhovikov moxobu...@gmail.com wrote: Subject: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config

Re: [PATCH][GSOC] Selection of the verbose message is replaced with generated message in install_branch_config()

2014-03-24 Thread Aleksey Mokhovikov
On 03/22/2014 04:13 AM, Michael Haggerty wrote: My expectation when I invented that microproject was that converting the code to be table-driven would be judged *not* to be an improvement. I was hoping that a student would say the 'if' statement is OK, but let's delete this ridiculous