Hi,
I did notice the problem a while ago and had traced it back to the
fact that the bash completion scripts no longer adds the trailing '/'
at the end of directories.
Tcsh needs that '/' to know not to add that annoying extra space.
Bash 3 needed to put it that trailing '/' but bash 4 did not.
r provides completions of directories/files.
Also add -d/--debug flag support to help troubleshoot
the script.
Signed-off-by: Marc Khouzam
---
I thought this would help when for people that experience issues with
the script.
Thanks!
Marc
contrib/completion/git-completion.t
On Fri, Apr 24, 2015 at 7:30 AM, SZEDER Gábor wrote:
> Hi,
>
> Quoting Marc Khouzam :
>>
>> Hi,
>>
>> I did notice the problem a while ago and had traced it back to the
>> fact that the bash completion scripts no longer adds the trailing '/'
>&g
completion support well
isolated without introducing excessive complexity.
Signed-off-by: Marc Khouzam
==
With the changes applied, tcsh users should:
#1) Copy both this file and the bash completion script to your
${HOME} directory
# using the names ${HOME}/.git-completion.tcsh and
${HOME
Thanks for the review.
On Tue, Nov 13, 2012 at 6:14 AM, SZEDER Gábor wrote:
> Hi,
>
> On Mon, Nov 12, 2012 at 03:07:46PM -0500, Marc Khouzam wrote:
>> Hi,
>
> [...]
>
>> Signed-off-by: Marc Khouzam
>
> [...]
>
>> Thanks
>>
>> Marc
&g
Thanks for the review. I wasn't aware that you were doing
a similar effort for zsh.
On Tue, Nov 13, 2012 at 1:31 PM, Felipe Contreras
wrote:
> On Mon, Nov 12, 2012 at 9:07 PM, Marc Khouzam wrote:
>
>> this patch allows tcsh-users to get the benefits of the awesome
>> git
On Tue, Nov 13, 2012 at 6:46 PM, SZEDER Gábor wrote:
> Hi,
>
> On Tue, Nov 13, 2012 at 03:12:44PM -0500, Marc Khouzam wrote:
>> >> +if [ -n "$1" ] ; then
>> >> + # If there is an argument, we know the script is being executed
>> >> + # so
Approach (A) was selected to keep the tcsh completion support well
isolated without introducing excessive complexity.
Signed-off-by: Marc Khouzam
---
Here is the updated version of the patch.
I got git send-email to work, so I hope the formatting will be correct.
Thanks in advance.
Marc
contrib
On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras
wrote:
> On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam wrote:
>> The current tcsh-completion support for Git, as can be found on the
>> Internet, takes the approach of defining the possible completions
>> explicitly. This
On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras
wrote:
> On Fri, Nov 16, 2012 at 3:39 PM, Marc Khouzam wrote:
>> On Thu, Nov 15, 2012 at 8:41 PM, Felipe Contreras
>> wrote:
>>> On Thu, Nov 15, 2012 at 12:51 PM, Marc Khouzam
>>> wrote:
>>>> Th
third script
Approach (C) was selected avoid any modification to git-completion.bash.
Signed-off-by: Marc Khouzam
---
Here's another version which adds contrib/completion/git-completion.tcsh but
does not modify contrib/completion/git-completion.bash at all.
(Sorry, but I still can't
On Fri, Nov 16, 2012 at 12:18 PM, Felipe Contreras
wrote:
> On Fri, Nov 16, 2012 at 4:48 PM, Marc Khouzam wrote:
>> On Fri, Nov 16, 2012 at 10:33 AM, Felipe Contreras
>> wrote:
>
>>> Is it possible to just check if this is a login shell?
>>
>> I thin
third script
Approach (C) was selected avoid any modification to git-completion.bash.
Signed-off-by: Marc Khouzam
---
As suggested, I put the 'sort | uniq' inside the script.
In that case, I don't need to worry about aliases since 'sort |uniq' will
be executed in bash
On Fri, Nov 16, 2012 at 4:56 PM, Felipe Contreras
wrote:
> On Fri, Nov 16, 2012 at 10:20 PM, Junio C Hamano wrote:
>
>> The point is not about the quality of zsh's emulation
>> of (k)sh when it is run under that mode, but is about not having to
>> have that logic in bash-only part in the first pl
On Sat, Nov 17, 2012 at 1:01 PM, Felipe Contreras
wrote:
>
>> I gather that using a wrapper for zsh causes concerns about
>> backwards-compatibility.
>
> I don't see any concerns.
>
>> if [[ -n ${ZSH_VERSION-} ]]; then
>> # replace below by zsh completion commands calling `bash
>> ${HOME}/.git-c
On Tue, Nov 20, 2012 at 10:15 AM, Felipe Contreras
wrote:
> On Tue, Nov 20, 2012 at 3:58 PM, Marc Khouzam wrote:
>
>> Hi,
>>
>> since there doesn't seem to be an agreement that the approach to achieve tcsh
>> git-completion would be useful for zsh (the othe
er
maint
master
maint
master
which, when passed to 'uniq -u' will remain the same.
But when dealing with 'git checkout mai', the list will be:
maint
maint
which happens to be sorted and will be emptied by 'uniq -u'.
The solution is to first call 'sor
On Thu, Nov 22, 2012 at 10:41 AM, Adam Tkac wrote:
> Hello all,
>
> attached patch fixes bash completion when `egrep` is aliased to `egrep
> --color=always`.
To avoid any aliases, it may be better to use
\egrep
This could be worthwhile for all utilities used by the script.
Just a thought.
Mar
er
maint
master
maint
master
which, when passed to 'uniq -u' will remain the same.
But when dealing with 'git checkout mai', the list will be:
maint
maint
which happens to be sorted and will be emptied by 'uniq -u'.
The solution is to first call 'sort&#
out mai', the list will be:
maint
maint
which happens to be sorted and will be emptied by 'uniq -u',
properly ignoring 'maint'.
A solution for preventing the completion script from suggesting
such invalid branch names is to first call 'sort' and then 'un
7;git checkout mai', the list will be:
maint
maint
which happens to be sorted and will be emptied by 'uniq -u',
properly ignoring 'maint'.
A solution for preventing the completion script from suggesting
such invalid branch names is to first call 'sort' and then &#x
;git' or 'gitk' commands,
while still getting completion to work.
A check for the presence of ${HOME}/.git-completion.bash is also
added to help the user make use of the script properly.
Signed-off-by: Marc Khouzam
---
This issue was reported by someone already making use of the tcs
On Tue, Nov 27, 2012 at 12:16 PM, Junio C Hamano wrote:
> The patch was linewrapped so I had to fix it up;
Sorry about that. I don't know if it is gmail, or the fact that I use
its web interface
that causes these problems.
> please double check
> what will be queued on 'pu' to make sure that I
mpletions are shown with their directory prefix.
- Completions containing shell variables are not handled.
- Completions with ~ as the first character are not handled.
Signed-off-by: Marc Khouzam
---
Beyond the described fix, this commit also improves minor aspects
of the script. Normally I would su
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo
> Sent: Friday, December 21, 2012 11:55 AM
> To: git@vger.kernel.org
> Cc: sze...@ira.uka.de; felipe.contre...@gmail.com; Manlio Perillo
> Subject: [PATCH v4] git-comple
> Junio C Hamano writes:
>
>> Marc Khouzam writes:
>>
>>> I've been playing with it but I'm not getting the expected
>>> behavior when I cd to a sub-directory.
>>
>> Thanks for testing. Manlio?
>
> Can you try the attached pa
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo
> Sent: Monday, January 07, 2013 8:43 AM
> To: Marc Khouzam
> Cc: Junio C Hamano; git@vger.kernel.org; sze...@ira.uka.de;
> felipe.contre...@gm
expected.
Signed-off-by: Marc Khouzam
---
This update is meant to have tcsh completion work better if the
feature "git-completion.bash: add support for path completion"
is accepted.
See http://www.mail-archive.com/git@vger.kernel.org/msg14137.html
This commit does not depend on that oth
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo
> Sent: Wednesday, January 09, 2013 2:17 PM
> To: git@vger.kernel.org
> Subject: git-completion.tcsh and git-completion.zsh are broken?
>
> -BEGIN PGP SIGNED MESSAG
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Ramkumar Ramachandra
> Sent: Friday, May 24, 2013 12:19 PM
> To: SZEDER Gábor
> Cc: Git List; Felipe Contreras
> Subject: Re: [QUERY] How do you sort completions?
>
> SZEDER Gábor wro
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo
> Sent: Monday, January 28, 2013 3:16 PM
> To: Junio C Hamano
> Cc: Michael J Gruber; wookietreiber; git@vger.kernel.org
> Subject: Re: [feature request] git add complet
> -Original Message-
> From: git-ow...@vger.kernel.org
> [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo
> Sent: Wednesday, January 30, 2013 1:24 PM
> To: Marc Khouzam
> Cc: 'Junio C Hamano'; 'Michael J Gruber'; 'wookietreib
sing a compatibility method available for older
bash versions.
Also, tcsh does not handle the colon as a completion
separator so we remove it from the list of separators.
Signed-off-by: Marc Khouzam
---
Hi,
Here is the update for tcsh completion which is needed to handle
the cool new path com
cript to keep the trailing slash.
This patch does this.
Also, tcsh does not handle the colon as a completion
separator so we remove it from the list of separators.
Signed-off-by: Marc Khouzam
Thanks
Marc
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
34 matches
Mail list logo
