Hi guys,
I wanted post you patch here for this bug, but I can't find primary
source of this problem [0], because I don't understand some ideas in the
code. So what I investigate:
Bug is reprodusible since git version 1.8.3.1 (may earlier 1.8.xx, but I
don't test it) to actual upstream
snip
Bug is reprodusible since git version 1.8.3.1 (may earlier 1.8.xx, but
I don't test it) to actual upstream version.
This problem doesn't exists in version 1.7.xx - or more precisely is
not reproducible. May this is reproducible
since commit 7218a215 - in this commit was added assert in
On 25.3.2015 23:53 Michael Haggerty wrote:
On 03/23/2015 05:04 PM, Petr Stodulka wrote:
git goes into an infinite loop due to broken symlink (minimal reproducer
[0]). Affected code is in function
resolve_ref_unsafe in file refs.c - notice 'stat_ref'. There is comment
about problem with race
Hi guys,
git goes into an infinite loop due to broken symlink (minimal reproducer
[0]). Affected code is in function
resolve_ref_unsafe in file refs.c - notice 'stat_ref'. There is comment
about problem with race condition, hovewer in that case it's regular broken
symlink which cause infinite
Hi folks,
can you someone look at it? Or were these troubles mentioned somewhere
earlier and I miss that?
On 2.6.2015 16:14, Petr Stodulka wrote:
request-pull prints incorrectly warn messages about not found commits
and man pages don't say
anything about todays changed behaviour. People
request-pull prints incorrectly warn messages about not found commits
and man pages don't say
anything about todays changed behaviour. People are confused and try
look for errors at wrong places.
At least these should be fixed/modified.
Warn massage says that commit can't be found ar remote,
On 4.2.2016 20:15, Junio C Hamano wrote:
> Petr Stodulka <pstod...@redhat.com> writes:
>
>> I found that license file COPYING is different as compared with
>> http://www.gnu.org/licenses/gpl-2.0.txt If I pass over with
>> Linus's preamble, change is only about w
Hi,
I found that license file COPYING is different as compared with
http://www.gnu.org/licenses/gpl-2.0.txt
If I pass over with Linus's preamble, change is only about whitespaces - tabs
vs. space.
Probably it's minor non-essential change, but some projects do this change, so
rather I ask about
ter if it is used or not. For me it's significant previous response
from Junio.
I am not familiar with git send-email, so:
===[PATCH 1/2]
From b2509773edf7e886513f450cb8e215a87278cdfc Mon Sep 17 00:00:00 2001
From: Petr Stodulka <pstod
On 8.2.2016 18:28, Junio C Hamano wrote:
> Petr Stodulka <pstod...@redhat.com> writes:
>
>> On 4.2.2016 20:15, Junio C Hamano wrote:
>>> Petr Stodulka <pstod...@redhat.com> writes:
>>>
>>>> I found that license file COPYING is different as
On 16.3.2016 19:48, Jeff King wrote:
> On Wed, Mar 16, 2016 at 07:05:49PM +0100, Petr Stodulka wrote:
>
>> according to commit 9831e92 (merge) there is maybe by mistake kept
>> declaration
>> of function path_name() in revision.h, whose definition was removed
>>
ae72c8f9085b3b7bd84f94f90ff5b0416db59d67 Mon Sep 17 00:00:00 2001
From: Petr Stodulka <pstod...@redhat.com>
Date: Wed, 16 Mar 2016 18:51:53 +0100
Subject: [PATCH] remove obsoleted function path_name() from header file
revision.h
The function was removed by commit 9831e92 due to possible security
issue.
---
revi
On 28.9.2016 18:05, Petr Stodulka wrote:
> Delegation of credentials is disabled by default in libcurl since
> version 7.21.7 due to security vulnerability CVE-2011-2192. Which
> makes troubles with GSS/kerberos authentication where delegation
> of credentials is required. This ca
with set expected parameter
since libcurl version 7.22.0.
This patch provides new configuration variable http.delegation
which corresponds to curl parameter "--delegation" (see man 1 curl).
The following values are supported:
* none (default).
* policy
* always
Signed-off-by: Petr Stodu
with set expected parameter
since libcurl version 7.22.0.
This patch provides new configuration variable http.delegation
which corresponds to curl parameter "--delegation" (see man 1 curl).
The following values are supported:
* none (default).
* policy
* always
Signed-off-by: Petr Stodu
Macro CURLAUTH_GSSNEGOTIATE is deprecated since cURL v7.38.0 and
should be used CURLAUTH_NEGOTIATE instead. For compatibility
with older versions of cURL is CURLAUTH_NEGOTIATE set as alias
to CURLAUTH_GSSNEGOTIATE
Signed-off-by: Petr Stodulka <pstod...@redhat.com>
---
http.c
On 28.9.2016 19:16, Jeff King wrote:
> On Wed, Sep 28, 2016 at 06:05:52PM +0200, Petr Stodulka wrote:
>
>> Delegation of credentials is disabled by default in libcurl since
>> version 7.21.7 due to security vulnerability CVE-2011-2192. Which
>> makes troubles with GSS
lookup to be retried. But in
this scenario, the retries all suffer from the same problem, causing
an infinite loop.
So put a limit (of 5) on the number of times that the stat_ref step
can be retried.
Based-on-patch-by: Petr Stodulka <pstod...@redhat.com>
Signed-off-by: Michael Haggerty <mhag.
git ls-tree goes into an infinite loop while serving pretty vanilla requests,
if the refs/heads/ directory contains a symlink that's broken. Added test
which check if git ends with expected exit code or timeout expires.
---
t/t3103-ls-tree-misc.sh | 9 +
1 file changed, 9 insertions(+)
nks"
Michael Haggerty (1):
resolve_ref_unsafe(): limit the number of "stat_ref" retries
Petr Stodulka (1):
Add test for ls-tree with broken symlink under refs/heads
refs/files-backend.c| 6 --
refs/refs-internal.h| 6 ++
t/t3103-ls-tree-misc.sh | 9 +
3 file
Thank you for info, I totally missed that. Yes, this fixes the issue
perfectly.
Petr
On 14.10.2016 15:42, Jeff King wrote:
> On Fri, Oct 14, 2016 at 03:16:50PM +0200, Petr Stodulka wrote:
>
>> I have realized that this wasn't fixed after all when refs.c
>> was "rewr
FYI,
I modified the patch slightly.
On 14.10.2016 15:16, Petr Stodulka wrote:
> From: Michael Haggerty <mhag...@alum.mit.edu>
>
> If there is a broken symlink where a loose reference file is expected,
> then the attempt to open() it fails with ENOENT. This error is
> m
22 matches
Mail list logo
