Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-13 Thread Junio C Hamano
Francesco Pretto writes: > Thanks for the comments, my replies below. Before, a couple of general > questions: > - I'm also writing some tests, should I commit them together with the > feature patch? > - to determine the attached/detached state I did this: > > head_detached= > if test "$(rev-pars

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-03 Thread Francesco Pretto
2014/1/3 Francesco Pretto : > Concluding, my point is that at the current state submodules in git > seem to be flawed because of the inconsistent HEAD state between "add" > and "update" users. With my patch applied the attached HEAD behavior > would be fully supported. At some point "git submodule

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-02 Thread Francesco Pretto
2014/1/3 Francesco Pretto : > Concluding, my point is that at the current state submodules in git > seem to be flawed because of the inconsistent HEAD state between "add" > and "update" users. With my patch applied the attached HEAD behavior > would be fully supported. At some point "git submodule

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-02 Thread Francesco Pretto
2014/1/2 Junio C Hamano : > Francesco Pretto writes: > >> by default "git submodule" performs its add or update operations on a >> detached >> HEAD. This works well when using an existing full-fledged/indipendent >> project as >> the submodule, as there's less frequent need to update it or commi

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-02 Thread Junio C Hamano
Francesco Pretto writes: > by default "git submodule" performs its add or update operations on a detached > HEAD. This works well when using an existing full-fledged/indipendent project > as > the submodule, as there's less frequent need to update it or commit back > changes. When the submodule

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2014-01-02 Thread Francesco Pretto
Thanks for the comments, my replies below. Before, a couple of general questions: - I'm also writing some tests, should I commit them together with the feature patch? - to determine the attached/detached state I did this: head_detached= if test "$(rev-parse --abbrev-ref HEAD)" = "HEAD" then he

Re: [PATCH/RFC] Introduce git submodule add|update --attach

2013-12-31 Thread Phil Hord
On Sun, Dec 29, 2013 at 8:49 PM, Francesco Pretto wrote: > > by default "git submodule" performs its add or update operations on a detached > HEAD. This works well when using an existing full-fledged/indipendent project > as > the submodule, as there's less frequent need to update it or commit ba

[PATCH/RFC] Introduce git submodule add|update --attach

2013-12-29 Thread Francesco Pretto
Hello everybody, by default "git submodule" performs its add or update operations on a detached HEAD. This works well when using an existing full-fledged/indipendent project as the submodule, as there's less frequent need to update it or commit back changes. When the submodule is actually a large