Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Duy Nguyen
On Thu, Jan 24, 2013 at 4:06 AM, Junio C Hamano wrote: > Jens Lehmann writes: > >> This is a false positive. The merge algorithm picked a fast-forward >> in a submodule as a proper merge result and records that in a >> gitlink. But as Duy pointed out this could be easily fixed by >> turning the r

Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Duy Nguyen
On Thu, Jan 24, 2013 at 12:01 AM, Junio C Hamano wrote: > I however have this suspicion that this will become a losing battle > and we would be better off getting rid of add_submodule_odb(); > instead operations that work across repositories will be done as a > subprocess, which will get us back c

Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Junio C Hamano
Jens Lehmann writes: > This is a false positive. The merge algorithm picked a fast-forward > in a submodule as a proper merge result and records that in a > gitlink. But as Duy pointed out this could be easily fixed by > turning the readonly flag off in that case. I see that as "easily circumven

Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Jens Lehmann
Am 23.01.2013 18:01, schrieb Junio C Hamano: > Nguyễn Thái Ngọc Duy writes: > >> add_submodule_odb() can be used to import objects from another >> repository temporarily. After this point we don't know which objects >> are ours, which are external. If we create an object that refers to an >> ext

Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > add_submodule_odb() can be used to import objects from another > repository temporarily. After this point we don't know which objects > are ours, which are external. If we create an object that refers to an > external object, next time git runs, it may find a hole

Re: [PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Duy Nguyen
On Wed, Jan 23, 2013 at 8:34 PM, Nguyễn Thái Ngọc Duy wrote: > add_submodule_odb() can be used to import objects from another > repository temporarily. After this point we don't know which objects > are ours, which are external. If we create an object that refers to an > external object, next time

[PATCH/RFC] Revoke write access to refs and odb after importing another repo's odb

2013-01-23 Thread Nguyễn Thái Ngọc Duy
add_submodule_odb() can be used to import objects from another repository temporarily. After this point we don't know which objects are ours, which are external. If we create an object that refers to an external object, next time git runs, it may find a hole in the object graph because the external