Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-26 Thread Junio C Hamano
Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-26 Thread René Scharfe
Sorry for being late. Just wanted to try out this new feature and ended up reading this old thread. Am 15.09.2012 01:18, schrieb Junio C Hamano: > t/perf/perf-lib.sh | 1 + > t/test-lib.sh | 26 -- > 2 files changed, 21 insertions(+), 6 deletions(-) > > diff --g

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-17 Thread Elia Pinto
Ok. Please use the patch that you have already queued in the ep integration branch. Thank you 2012/9/17, Junio C Hamano : > Elia Pinto writes: > >>> - That "165" thing I mentioned earlier. >> >> Thank you so much for the comments, that's fine. A single >> consideration for MALLOC_PERTURB. >>

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-17 Thread Junio C Hamano
Elia Pinto writes: >> - That "165" thing I mentioned earlier. > > Thank you so much for the comments, that's fine. A single > consideration for MALLOC_PERTURB. > > You can use any value between 1..255 for MALLOC_PERTURB_ > That chooses the byte that glibc will use to memset all freed buffers. >

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-17 Thread Elia Pinto
2012/9/15 Junio C Hamano : > Junio C Hamano writes: > >> Elia Pinto writes: >> >>> Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) >>> include a malloc() implementation which is tunable via environment >>> variables. When MALLOC_CHECK_ is set, a special (less efficient) >>> impl

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-14 Thread Junio C Hamano
Junio C Hamano writes: > Elia Pinto writes: > >> Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) >> include a malloc() implementation which is tunable via environment >> variables. When MALLOC_CHECK_ is set, a special (less efficient) >> implementation is used which is designed

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-14 Thread Junio C Hamano
Elia Pinto writes: > Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) > include a malloc() implementation which is tunable via environment > variables. When MALLOC_CHECK_ is set, a special (less efficient) > implementation is used which is designed to be tolerant against > simple

[PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-14 Thread Elia Pinto
Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) include a malloc() implementation which is tunable via environment variables. When MALLOC_CHECK_ is set, a special (less efficient) implementation is used which is designed to be tolerant against simple errors, such as double calls o

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-13 Thread Junio C Hamano
Elia Pinto writes: > 2012/9/12 Junio C Hamano : >> >> Interesting, but it bothers me to make it enabled unconditionally. >> At least, this shouldn't be enabled under GIT_TEST_OPTS=--valgrind, no? > Sorry for the late response and thanks. > > No, setting MALLOC_CHECK don't require > valgrind ...

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-13 Thread Elia Pinto
2012/9/12 Junio C Hamano : > > Interesting, but it bothers me to make it enabled unconditionally. > At least, this shouldn't be enabled under GIT_TEST_OPTS=--valgrind, no? Sorry for the late response and thanks. No, setting MALLOC_CHECK don't require valgrind and it considered a best QA to have th

Re: [PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-12 Thread Junio C Hamano
Elia Pinto writes: > Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) > include a malloc() implementation which is tunable via environment > variables. When MALLOC_CHECK_ is set, a special (less efficient) > implementation is used which is designed to be tolerant against > simple

[PATCH] Add MALLOC_CHECK_ and MALLOC_PERTURB_ libc env to the test suite for detecting heap corruption

2012-09-12 Thread Elia Pinto
Recent versions of Linux libc (later than 5.4.23) and glibc (2.x) include a malloc() implementation which is tunable via environment variables. When MALLOC_CHECK_ is set, a special (less efficient) implementation is used which is designed to be tolerant against simple errors, such as double calls o