Re: [PATCH] Fix "t0001: test git init when run via an alias"

2014-06-12 Thread Junio C Hamano
Duy Nguyen writes: > On Wed, Jun 11, 2014 at 1:48 AM, Junio C Hamano wrote: >> Nguyễn Thái Ngọc Duy writes: >> >>> Commit 4ad8332 (t0001: test git init when run via an alias - >>> 2010-11-26) noted breakages when running init via alias. The problem >>> is for alias to be used, $GIT_DIR must be

Re: [PATCH] Fix "t0001: test git init when run via an alias"

2014-06-11 Thread Duy Nguyen
On Wed, Jun 11, 2014 at 1:48 AM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Commit 4ad8332 (t0001: test git init when run via an alias - >> 2010-11-26) noted breakages when running init via alias. The problem >> is for alias to be used, $GIT_DIR must be searched, but 'init' and >>

Re: [PATCH] Fix "t0001: test git init when run via an alias"

2014-06-10 Thread Junio C Hamano
Oops; obviously the check must be for NULL-ness, i.e. if (!getcwd(...)) die_errno(...); On Tue, Jun 10, 2014 at 11:53 AM, Junio C Hamano wrote: > I'd squash this in, though. > > git.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/git.c b/git.c > index 6bb2043..

Re: [PATCH] Fix "t0001: test git init when run via an alias"

2014-06-10 Thread Junio C Hamano
I'd squash this in, though. git.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/git.c b/git.c index 6bb2043..9bfa8fb 100644 --- a/git.c +++ b/git.c @@ -36,7 +36,8 @@ static void save_env(void) if (saved_environment) return; saved_environment

Re: [PATCH] Fix "t0001: test git init when run via an alias"

2014-06-10 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Commit 4ad8332 (t0001: test git init when run via an alias - > 2010-11-26) noted breakages when running init via alias. The problem > is for alias to be used, $GIT_DIR must be searched, but 'init' and > 'clone' are not happy with that. So we start a new process lik

[PATCH] Fix "t0001: test git init when run via an alias"

2014-06-08 Thread Nguyễn Thái Ngọc Duy
Commit 4ad8332 (t0001: test git init when run via an alias - 2010-11-26) noted breakages when running init via alias. The problem is for alias to be used, $GIT_DIR must be searched, but 'init' and 'clone' are not happy with that. So we start a new process like an external command, with clean enviro