Re: [PATCH] More typofixes.

[Junio C Hamano]

Marc Branchaud  writes:

> On 13-07-29 01:52 PM, Junio C Hamano wrote:
>> Here is what I salvaged for 'maint'.  Eyeballing by others is very
>> much appreciated.
>> 
>> -- >8 --
>> From: Ondřej Bílka 
>> Subject: [PATCH] many small typofixes
>> Date: Mon, 29 Jul 2013 10:18:21 +0200
>> 
>> Signed-off-by: Ondřej Bílka 
>> Signed-off-by: Junio C Hamano 
>
> Looks good.
>
> Reviewed-by: Marc Branchaud 
>
>   M.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[Marc Branchaud]

On 13-07-29 01:52 PM, Junio C Hamano wrote:
> Here is what I salvaged for 'maint'.  Eyeballing by others is very
> much appreciated.
> 
> -- >8 --
> From: Ondřej Bílka 
> Subject: [PATCH] many small typofixes
> Date: Mon, 29 Jul 2013 10:18:21 +0200
> 
> Signed-off-by: Ondřej Bílka 
> Signed-off-by: Junio C Hamano 

Looks good.

Reviewed-by: Marc Branchaud 

M.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[Stefan Beller]

On 07/29/2013 07:52 PM, Junio C Hamano wrote:
> Junio C Hamano  writes:
> 
>> Marc Branchaud  writes:
>>
>>> Unfortunately no automated system is perfect (see some of my comments 
>>> below).
>>>  I'm all for an automated system that identifies potential misspellings, but
>>> I'm wary of anything that attempts to automatically correct perceived 
>>> errors,
>>> or that can't be overruled.  In the end a human must make the final 
>>> decision.
>>
>> I'd actually prefer to see no patch that says "this was done with an
>> automatic tool".  You can use automation on your end all you want,
>> but the final result needs to be eyeballed before sending it out,
>> and at that point both the credit and the blame lies on you, not any
>> automated tool.
>>
  core.sharedRepository::
 -  When 'group' (or 'true'), the repository is made shareable between
 +  When 'group' (or 'true'), the repository is made sharable between
several users in a group (making sure all the files and objects are
group-writable). When 'all' (or 'world' or 'everybody'), the
repository will be readable by all users, additionally to being
 -  group-shareable. When 'umask' (or 'false'), Git will use permissions
 +  group-sharable. When 'umask' (or 'false'), Git will use permissions
>>>
>>> "Sharable" is the North American spelling.  AFAIK git doesn't specify what
>>> kind of English the documentation source files should use.  Perhaps one day
>>> there'll be en_UK and en_US translations, and all the sources will be 
>>> written
>>> in Klingon...
>>
>> ;-)
>>
>> It often is a good idea to ask your search engine "What is X", and I
>> seem to get a positive result for "what is shareable" just fine.
> 
> Here is what I salvaged for 'maint'.  Eyeballing by others is very
> much appreciated.
> 
> -- >8 --
> From: Ondřej Bílka 
> Subject: [PATCH] many small typofixes
> Date: Mon, 29 Jul 2013 10:18:21 +0200
> 
> Signed-off-by: Ondřej Bílka 
> Signed-off-by: Junio C Hamano 
> ---
>  Documentation/howto/new-command.txt  | 2 +-
>  Documentation/technical/api-revision-walking.txt | 2 +-
>  builtin/fast-export.c| 2 +-
>  builtin/push.c   | 2 +-
>  cache.h  | 2 +-
>  combine-diff.c   | 2 +-
>  contrib/ciabot/ciabot.py | 2 +-
>  contrib/ciabot/ciabot.sh | 4 ++--
>  contrib/subtree/git-subtree.txt  | 2 +-
>  git-mergetool--lib.sh| 2 +-
>  git-p4.py| 2 +-
>  notes.h  | 2 +-
>  read-cache.c | 4 ++--
>  t/gitweb-lib.sh  | 2 +-
>  t/lib-t6000.sh   | 2 +-
>  t/t7601-merge-pull-config.sh | 2 +-
>  t/t9020-remote-svn.sh| 2 +-
>  t/t9112-git-svn-md5less-file.sh  | 2 +-
>  t/t9802-git-p4-filetype.sh   | 2 +-
>  transport-helper.c   | 4 ++--
>  20 files changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/Documentation/howto/new-command.txt 
> b/Documentation/howto/new-command.txt
> index 2abc3a0..d7de5a3 100644
> --- a/Documentation/howto/new-command.txt
> +++ b/Documentation/howto/new-command.txt
> @@ -94,7 +94,7 @@ your language, document it in the INSTALL file.
>  6. There is a file command-list.txt in the distribution main directory
>  that categorizes commands by type, so they can be listed in appropriate
>  subsections in the documentation's summary command list.  Add an entry
> -for yours.  To understand the categories, look at git-cmmands.txt
> +for yours.  To understand the categories, look at git-commands.txt
>  in the main directory.
>  
>  7. Give the maintainer one paragraph to include in the RelNotes file
> diff --git a/Documentation/technical/api-revision-walking.txt 
> b/Documentation/technical/api-revision-walking.txt
> index b7d0d9a..55b878a 100644
> --- a/Documentation/technical/api-revision-walking.txt
> +++ b/Documentation/technical/api-revision-walking.txt
> @@ -59,7 +59,7 @@ function.
>  `reset_revision_walk`::
>  
>   Reset the flags used by the revision walking api. You can use
> - this to do multiple sequencial revision walks.
> + this to do multiple sequential revision walks.
>  
>  Data structures
>  ---
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index d60d675..0c8d250 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -379,7 +379,7 @@ static void handle_tag(const char *name, struct tag *tag)
>   int tagged_mark;
>   struct commit *p;
>  
> - /* Trees have no identifer in fast-export output, thus we have no way
> + /* Trees have no identifier in fast-export output, thus we have no way
>* to

Re: [PATCH] More typofixes.

[Junio C Hamano]

Junio C Hamano  writes:

> Marc Branchaud  writes:
>
>> Unfortunately no automated system is perfect (see some of my comments below).
>>  I'm all for an automated system that identifies potential misspellings, but
>> I'm wary of anything that attempts to automatically correct perceived errors,
>> or that can't be overruled.  In the end a human must make the final decision.
>
> I'd actually prefer to see no patch that says "this was done with an
> automatic tool".  You can use automation on your end all you want,
> but the final result needs to be eyeballed before sending it out,
> and at that point both the credit and the blame lies on you, not any
> automated tool.
>
>>>  core.sharedRepository::
>>> -   When 'group' (or 'true'), the repository is made shareable between
>>> +   When 'group' (or 'true'), the repository is made sharable between
>>> several users in a group (making sure all the files and objects are
>>> group-writable). When 'all' (or 'world' or 'everybody'), the
>>> repository will be readable by all users, additionally to being
>>> -   group-shareable. When 'umask' (or 'false'), Git will use permissions
>>> +   group-sharable. When 'umask' (or 'false'), Git will use permissions
>>
>> "Sharable" is the North American spelling.  AFAIK git doesn't specify what
>> kind of English the documentation source files should use.  Perhaps one day
>> there'll be en_UK and en_US translations, and all the sources will be written
>> in Klingon...
>
> ;-)
>
> It often is a good idea to ask your search engine "What is X", and I
> seem to get a positive result for "what is shareable" just fine.

Here is what I salvaged for 'maint'.  Eyeballing by others is very
much appreciated.

-- >8 --
From: Ondřej Bílka 
Subject: [PATCH] many small typofixes
Date: Mon, 29 Jul 2013 10:18:21 +0200

Signed-off-by: Ondřej Bílka 
Signed-off-by: Junio C Hamano 
---
 Documentation/howto/new-command.txt  | 2 +-
 Documentation/technical/api-revision-walking.txt | 2 +-
 builtin/fast-export.c| 2 +-
 builtin/push.c   | 2 +-
 cache.h  | 2 +-
 combine-diff.c   | 2 +-
 contrib/ciabot/ciabot.py | 2 +-
 contrib/ciabot/ciabot.sh | 4 ++--
 contrib/subtree/git-subtree.txt  | 2 +-
 git-mergetool--lib.sh| 2 +-
 git-p4.py| 2 +-
 notes.h  | 2 +-
 read-cache.c | 4 ++--
 t/gitweb-lib.sh  | 2 +-
 t/lib-t6000.sh   | 2 +-
 t/t7601-merge-pull-config.sh | 2 +-
 t/t9020-remote-svn.sh| 2 +-
 t/t9112-git-svn-md5less-file.sh  | 2 +-
 t/t9802-git-p4-filetype.sh   | 2 +-
 transport-helper.c   | 4 ++--
 20 files changed, 23 insertions(+), 23 deletions(-)

diff --git a/Documentation/howto/new-command.txt 
b/Documentation/howto/new-command.txt
index 2abc3a0..d7de5a3 100644
--- a/Documentation/howto/new-command.txt
+++ b/Documentation/howto/new-command.txt
@@ -94,7 +94,7 @@ your language, document it in the INSTALL file.
 6. There is a file command-list.txt in the distribution main directory
 that categorizes commands by type, so they can be listed in appropriate
 subsections in the documentation's summary command list.  Add an entry
-for yours.  To understand the categories, look at git-cmmands.txt
+for yours.  To understand the categories, look at git-commands.txt
 in the main directory.
 
 7. Give the maintainer one paragraph to include in the RelNotes file
diff --git a/Documentation/technical/api-revision-walking.txt 
b/Documentation/technical/api-revision-walking.txt
index b7d0d9a..55b878a 100644
--- a/Documentation/technical/api-revision-walking.txt
+++ b/Documentation/technical/api-revision-walking.txt
@@ -59,7 +59,7 @@ function.
 `reset_revision_walk`::
 
Reset the flags used by the revision walking api. You can use
-   this to do multiple sequencial revision walks.
+   this to do multiple sequential revision walks.
 
 Data structures
 ---
diff --git a/builtin/fast-export.c b/builtin/fast-export.c
index d60d675..0c8d250 100644
--- a/builtin/fast-export.c
+++ b/builtin/fast-export.c
@@ -379,7 +379,7 @@ static void handle_tag(const char *name, struct tag *tag)
int tagged_mark;
struct commit *p;
 
-   /* Trees have no identifer in fast-export output, thus we have no way
+   /* Trees have no identifier in fast-export output, thus we have no way
 * to output tags of trees, tags of tags of trees, etc.  Simply omit
 * such tags.
 */
diff --git a/builtin/push.c b/builtin/push.c
index 2d84d10..795197a 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -92,7 

Re: [PATCH] More typofixes.

[Junio C Hamano]

Marc Branchaud  writes:

> Unfortunately no automated system is perfect (see some of my comments below).
>  I'm all for an automated system that identifies potential misspellings, but
> I'm wary of anything that attempts to automatically correct perceived errors,
> or that can't be overruled.  In the end a human must make the final decision.

I'd actually prefer to see no patch that says "this was done with an
automatic tool".  You can use automation on your end all you want,
but the final result needs to be eyeballed before sending it out,
and at that point both the credit and the blame lies on you, not any
automated tool.

>>  core.sharedRepository::
>> -When 'group' (or 'true'), the repository is made shareable between
>> +When 'group' (or 'true'), the repository is made sharable between
>>  several users in a group (making sure all the files and objects are
>>  group-writable). When 'all' (or 'world' or 'everybody'), the
>>  repository will be readable by all users, additionally to being
>> -group-shareable. When 'umask' (or 'false'), Git will use permissions
>> +group-sharable. When 'umask' (or 'false'), Git will use permissions
>
> "Sharable" is the North American spelling.  AFAIK git doesn't specify what
> kind of English the documentation source files should use.  Perhaps one day
> there'll be en_UK and en_US translations, and all the sources will be written
> in Klingon...

;-)

It often is a good idea to ask your search engine "What is X", and I
seem to get a positive result for "what is shareable" just fine.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[Ondřej Bílka]

On Mon, Jul 29, 2013 at 10:55:41AM -0400, Marc Branchaud wrote:
> On 13-07-29 04:18 AM, Ondřej Bílka wrote:
> > Hi,
> > 
> > I improved my tool and it catched following additional typos.
> > 
> > As with any big project best way to catch errors is to have automated
> > checks that catch them ( Other possibility would be to read everything ten
> > times to get error rate down but nobody wants to do it).
> > 
> > If you want you could add a pre-commit hook 
> > stylepp-spellcheck --hook
> > that checks comments for likely typos (misspells by aspell and not
> > occurring in code). It uses aspell to identify them so you need to 
> > teach aspell which words are valid. 
> > 
> > I would like make possible to share dictionaries so teaching phase can
> > be done only once instead for each person but I did not found suitable
> > workflow yet.
> 
> Unfortunately no automated system is perfect (see some of my comments below).
>  I'm all for an automated system that identifies potential misspellings, but

> > that checks comments for likely typos (misspells by aspell and not
> > occurring in code)

It just prints likely typos, nothing more. 

> I'm wary of anything that attempts to automatically correct perceived errors,
> or that can't be overruled.  In the end a human must make the final decision.
> 
Its more about minimizing time human must spend to review.
It is faster to read sentences with corrections and check if they make
sense and fix few that do not than switching between find typo, 
read sentence, look up alternatives, decide which one makes sense.

It is natural that there will be errors in generated corrections; I lack
neccessary domain knowledge for start.

> > Signed-off-by: Ondřej Bílka 
> > 
> > diff --git a/pathspec.c b/pathspec.c
> > index 6ea0867..27ffe77 100644
> > --- a/pathspec.c
> > +++ b/pathspec.c
> > @@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char 
> > **pathspec,
> >  /*
> >   * Finds which of the given pathspecs match items in the index.
> >   *
> > - * This is a one-shot wrapper around add_pathspec_matches_against_index()
> > + * This is an one-shot wrapper around add_pathspec_matches_against_index()
> 
> As many others have already said, this is not a typo.
> 
> The use of "a" or "an" depends on whether or not the O's sound is hard or
> soft.  So although we say "an orange" we also say "a one-in-a-million chance".
> 
Well it slipped through my filter and review. Ideally a script could
just look up pronunciation in dictionary but I did not find downloadable
one yet.

> > 
> >  [ ... snip ... ]
> > 
> 
> > diff --git a/Documentation/RelNotes/1.7.9.1.txt 
> > b/Documentation/RelNotes/1.7.9.1.txt
> > index 6957183..e8fddb8 100644
> > --- a/Documentation/RelNotes/1.7.9.1.txt
> > +++ b/Documentation/RelNotes/1.7.9.1.txt
> > @@ -20,7 +20,7 @@ Fixes since v1.7.9
> > submodule that only has uncommitted local changes in the patch
> > prepared by for the user to edit.
> >  
> > - * Typo in "git branch --edit-description my-tpoic" was not diagnosed.
> > + * Typo in "git branch --edit-description my-topic" was not diagnosed.
> 
> Here "tpoic" is illustrating the typo that was being misdiagnosed.
> 
yes, domain knowledge.
> > 
> >  [ ... snip ... ]
> > 
> 
> > diff --git a/Documentation/config.txt b/Documentation/config.txt
> > index e0b923f..8420aff 100644
> > --- a/Documentation/config.txt
> > +++ b/Documentation/config.txt
> > @@ -434,11 +434,11 @@ core.repositoryFormatVersion::
> > version.
> >  
> >  core.sharedRepository::
> > -   When 'group' (or 'true'), the repository is made shareable between
> > +   When 'group' (or 'true'), the repository is made sharable between
> > several users in a group (making sure all the files and objects are
> > group-writable). When 'all' (or 'world' or 'everybody'), the
> > repository will be readable by all users, additionally to being
> > -   group-shareable. When 'umask' (or 'false'), Git will use permissions
> > +   group-sharable. When 'umask' (or 'false'), Git will use permissions
> 
> "Sharable" is the North American spelling.  AFAIK git doesn't specify what
> kind of English the documentation source files should use.  Perhaps one day
> there'll be en_UK and en_US translations, and all the sources will be written
> in Klingon...
> 
> Until that day, or until the git project starts to care a lot more about
> English style, I think patches that translate spellings between English
> variants are a bit of a waste of time.
> 
I need better dictionary that aspell currently has.

My replacements were mostly generated from commit histories of several projects
where I looked when wrong word changes to correct one and letters stay
mostly same. 

This caused false positives like this.

> > 
> >  [ ... snip ... ]
> > 
> 
> > diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt
> > index fe723e4..1491d69 100644
> > --- a/Documentation/user-manual.txt
> > +++ b/Documentation/user-manual.txt
> > @@ -311

Re: [PATCH] More typofixes.

[Marc Branchaud]

On 13-07-29 04:18 AM, Ondřej Bílka wrote:
> Hi,
> 
> I improved my tool and it catched following additional typos.
> 
> As with any big project best way to catch errors is to have automated
> checks that catch them ( Other possibility would be to read everything ten
> times to get error rate down but nobody wants to do it).
> 
> If you want you could add a pre-commit hook 
> stylepp-spellcheck --hook
> that checks comments for likely typos (misspells by aspell and not
> occurring in code). It uses aspell to identify them so you need to 
> teach aspell which words are valid. 
> 
> I would like make possible to share dictionaries so teaching phase can
> be done only once instead for each person but I did not found suitable
> workflow yet.

Unfortunately no automated system is perfect (see some of my comments below).
 I'm all for an automated system that identifies potential misspellings, but
I'm wary of anything that attempts to automatically correct perceived errors,
or that can't be overruled.  In the end a human must make the final decision.

> Signed-off-by: Ondřej Bílka 
> 
> diff --git a/pathspec.c b/pathspec.c
> index 6ea0867..27ffe77 100644
> --- a/pathspec.c
> +++ b/pathspec.c
> @@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char 
> **pathspec,
>  /*
>   * Finds which of the given pathspecs match items in the index.
>   *
> - * This is a one-shot wrapper around add_pathspec_matches_against_index()
> + * This is an one-shot wrapper around add_pathspec_matches_against_index()

As many others have already said, this is not a typo.

The use of "a" or "an" depends on whether or not the O's sound is hard or
soft.  So although we say "an orange" we also say "a one-in-a-million chance".

> 
>  [ ... snip ... ]
> 

> diff --git a/Documentation/RelNotes/1.7.9.1.txt 
> b/Documentation/RelNotes/1.7.9.1.txt
> index 6957183..e8fddb8 100644
> --- a/Documentation/RelNotes/1.7.9.1.txt
> +++ b/Documentation/RelNotes/1.7.9.1.txt
> @@ -20,7 +20,7 @@ Fixes since v1.7.9
> submodule that only has uncommitted local changes in the patch
> prepared by for the user to edit.
>  
> - * Typo in "git branch --edit-description my-tpoic" was not diagnosed.
> + * Typo in "git branch --edit-description my-topic" was not diagnosed.

Here "tpoic" is illustrating the typo that was being misdiagnosed.

> 
>  [ ... snip ... ]
> 

> diff --git a/Documentation/config.txt b/Documentation/config.txt
> index e0b923f..8420aff 100644
> --- a/Documentation/config.txt
> +++ b/Documentation/config.txt
> @@ -434,11 +434,11 @@ core.repositoryFormatVersion::
>   version.
>  
>  core.sharedRepository::
> - When 'group' (or 'true'), the repository is made shareable between
> + When 'group' (or 'true'), the repository is made sharable between
>   several users in a group (making sure all the files and objects are
>   group-writable). When 'all' (or 'world' or 'everybody'), the
>   repository will be readable by all users, additionally to being
> - group-shareable. When 'umask' (or 'false'), Git will use permissions
> + group-sharable. When 'umask' (or 'false'), Git will use permissions

"Sharable" is the North American spelling.  AFAIK git doesn't specify what
kind of English the documentation source files should use.  Perhaps one day
there'll be en_UK and en_US translations, and all the sources will be written
in Klingon...

Until that day, or until the git project starts to care a lot more about
English style, I think patches that translate spellings between English
variants are a bit of a waste of time.

> 
>  [ ... snip ... ]
> 

> diff --git a/Documentation/user-manual.txt b/Documentation/user-manual.txt
> index fe723e4..1491d69 100644
> --- a/Documentation/user-manual.txt
> +++ b/Documentation/user-manual.txt
> @@ -3116,7 +3116,7 @@ Trust
>  If you receive the SHA-1 name of a blob from one source, and its contents
>  from another (possibly untrusted) source, you can still trust that those
>  contents are correct as long as the SHA-1 name agrees.  This is because
> -the SHA-1 is designed so that it is infeasible to find different contents
> +the SHA-1 is designed so that it is unfeasible to find different contents
>  that produce the same hash.
>  
>  Similarly, you need only trust the SHA-1 name of a top-level tree object

Both "infeasible" and "unfeasible" are in common usage.  If you want to avoid
future patches going back and forth on this, try "not feasible".

M.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[Ramkumar Ramachandra]

Ondřej Bílka wrote:
> diff --git a/builtin/log.c b/builtin/log.c
> index 2625f98..01b49b3 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -304,7 +304,7 @@ static void setup_early_output(struct rev_info *rev)
>  * tenth of a second, don't even bother doing the
>  * early-output thing..
>  *
> -* This is a one-time-only trigger.
> +* This is an one-time-only trigger.

I didn't look through your patch in detail, but this one caught my
eye: it's incorrect.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[David Aguilar]

On Mon, Jul 29, 2013 at 1:18 AM, Ondřej Bílka  wrote:
> Hi,
>
> I improved my tool and it catched following additional typos.
>
> As with any big project best way to catch errors is to have automated
> checks that catch them ( Other possibility would be to read everything ten
> times to get error rate down but nobody wants to do it).
>
> If you want you could add a pre-commit hook
> stylepp-spellcheck --hook
> that checks comments for likely typos (misspells by aspell and not
> occurring in code). It uses aspell to identify them so you need to
> teach aspell which words are valid.
>
> I would like make possible to share dictionaries so teaching phase can
> be done only once instead for each person but I did not found suitable
> workflow yet.
>
>
> Signed-off-by: Ondřej Bílka 
>
> diff --git a/pathspec.c b/pathspec.c
> index 6ea0867..27ffe77 100644
> --- a/pathspec.c
> +++ b/pathspec.c
> @@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char 
> **pathspec,
>  /*
>   * Finds which of the given pathspecs match items in the index.
>   *
> - * This is a one-shot wrapper around add_pathspec_matches_against_index()
> + * This is an one-shot wrapper around add_pathspec_matches_against_index()

"one" is pronounced like "wun" so we use "a" instead of "an" here.
These should stay as-is.
-- 
David
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] More typofixes.

[Bryan Turner]

> diff --git a/pathspec.c b/pathspec.c
> index 6ea0867..27ffe77 100644
> --- a/pathspec.c
> +++ b/pathspec.c
> @@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char 
> **pathspec,
>  /*
>   * Finds which of the given pathspecs match items in the index.
>   *
> - * This is a one-shot wrapper around add_pathspec_matches_against_index()
> + * This is an one-shot wrapper around add_pathspec_matches_against_index()
>   * which allocates, populates, and returns a seen[] array indicating the
>   * nature of the "closest" (i.e. most specific) matches which each of the
>   * given pathspecs achieves against all items in the index.
>
>
> diff --git a/builtin/log.c b/builtin/log.c
> index 2625f98..01b49b3 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -304,7 +304,7 @@ static void setup_early_output(struct rev_info *rev)
>  * tenth of a second, don't even bother doing the
>  * early-output thing..
>  *
> -* This is a one-time-only trigger.
> +* This is an one-time-only trigger.
>  */
> early_output_timer.it_value.tv_sec = 0;
> early_output_timer.it_value.tv_usec = 10;

These two are not typos. "This is a one-time" is grammatically correct.

>
> diff --git a/commit-slab.h b/commit-slab.h
> index 7d48163..4f1c796 100644
> --- a/commit-slab.h
> +++ b/commit-slab.h
> @@ -22,7 +22,7 @@
>   *
>   *   Initializes the indegree slab that associates an array of integers
>   *   to each commit. 'stride' specifies how big each array is.  The slab
> - *   that id initialied by the variant without "_with_stride" associates
> + *   that id initialized by the variant without "_with_stride" associates
>   *   each commit with an array of one integer.
>   */

To my reading, it seems like that "id" should be "is", in addition to
the typo with "initialized"

That's a pretty impressive list of corrections.

Reviewed-by: Bryan Turner 
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] More typofixes.

[Ondřej Bílka]

Hi,

I improved my tool and it catched following additional typos.

As with any big project best way to catch errors is to have automated
checks that catch them ( Other possibility would be to read everything ten
times to get error rate down but nobody wants to do it).

If you want you could add a pre-commit hook 
stylepp-spellcheck --hook
that checks comments for likely typos (misspells by aspell and not
occurring in code). It uses aspell to identify them so you need to 
teach aspell which words are valid. 

I would like make possible to share dictionaries so teaching phase can
be done only once instead for each person but I did not found suitable
workflow yet.


Signed-off-by: Ondřej Bílka 

diff --git a/pathspec.c b/pathspec.c
index 6ea0867..27ffe77 100644
--- a/pathspec.c
+++ b/pathspec.c
@@ -40,7 +40,7 @@ void add_pathspec_matches_against_index(const char **pathspec,
 /*
  * Finds which of the given pathspecs match items in the index.
  *
- * This is a one-shot wrapper around add_pathspec_matches_against_index()
+ * This is an one-shot wrapper around add_pathspec_matches_against_index()
  * which allocates, populates, and returns a seen[] array indicating the
  * nature of the "closest" (i.e. most specific) matches which each of the
  * given pathspecs achieves against all items in the index.
diff --git a/builtin/log.c b/builtin/log.c
index 2625f98..01b49b3 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -304,7 +304,7 @@ static void setup_early_output(struct rev_info *rev)
 * tenth of a second, don't even bother doing the
 * early-output thing..
 *
-* This is a one-time-only trigger.
+* This is an one-time-only trigger.
 */
early_output_timer.it_value.tv_sec = 0;
early_output_timer.it_value.tv_usec = 10;
diff --git a/transport-helper.c b/transport-helper.c
index 45a35df..63cabc3 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -1132,7 +1132,7 @@ static void *udt_copy_task_routine(void *udt)
 #ifndef NO_PTHREADS
 
 /*
- * Join thread, with apporiate errors on failure. Name is name for the
+ * Join thread, with appropriate errors on failure. Name is name for the
  * thread (for error messages). Returns 0 on success, 1 on failure.
  */
 static int tloop_join(pthread_t thread, const char *name)
diff --git a/transport-helper.c b/transport-helper.c
index 45a35df..63cabc3 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -1198,7 +1198,7 @@ static void udt_kill_transfer(struct 
unidirectional_transfer *t)
 }
 
 /*
- * Join process, with apporiate errors on failure. Name is name for the
+ * Join process, with appropriate errors on failure. Name is name for the
  * process (for error messages). Returns 0 on success, 1 on failure.
  */
 static int tloop_join(pid_t pid, const char *name)
diff --git a/Documentation/RelNotes/1.7.11.7.txt 
b/Documentation/RelNotes/1.7.11.7.txt
index e7e79d9..e743a2a 100644
--- a/Documentation/RelNotes/1.7.11.7.txt
+++ b/Documentation/RelNotes/1.7.11.7.txt
@@ -25,7 +25,7 @@ Fixes since v1.7.11.6
references" nor "Reload" did not update what is shown as the
contents of it, when the user overwrote the tag with "git tag -f".
 
- * "git for-each-ref" did not currectly support more than one --sort
+ * "git for-each-ref" did not correctly support more than one --sort
option.
 
  * "git log .." errored out saying it is both rev range and a path
diff --git a/t/t9112-git-svn-md5less-file.sh b/t/t9112-git-svn-md5less-file.sh
index a61d671..9861c71 100755
--- a/t/t9112-git-svn-md5less-file.sh
+++ b/t/t9112-git-svn-md5less-file.sh
@@ -7,7 +7,7 @@ test_description='test that git handles an svn repository with 
missing md5sums'
 # Loading a node from a svn dumpfile without a Text-Content-Length
 # field causes svn to neglect to store or report an md5sum.  (it will
 # calculate one if you had put Text-Content-Length: 0).  This showed
-# up in a repository creted with cvs2svn.
+# up in a repository created with cvs2svn.
 
 cat > dumpfile.svn src;
/*
-* Don't show advice for people who explicitely set
+* Don't show advice for people who explicitly set
 * push.default.
 */
if (push_default == PUSH_DEFAULT_UNSPECIFIED)
diff --git a/Documentation/howto/new-command.txt 
b/Documentation/howto/new-command.txt
index 2abc3a0..d7de5a3 100644
--- a/Documentation/howto/new-command.txt
+++ b/Documentation/howto/new-command.txt
@@ -94,7 +94,7 @@ your language, document it in the INSTALL file.
 6. There is a file command-list.txt in the distribution main directory
 that categorizes commands by type, so they can be listed in appropriate
 subsections in the documentation's summary command list.  Add an entry
-for yours.  To understand the categories, look at git-cmmands.txt
+for yours.  To understand the categories, look at git-commands.txt
 in the main directory.
 
 7. Give the maintainer one paragraph to include in the RelNotes file
diff --git a/t/lib-t600