Re: [PATCH] Standardize python shebangs

2014-05-08 Thread Johan Herland
On Thu, May 8, 2014 at 1:48 PM, Matthieu Moy wrote: > It is very important that git-multimail keeps running with Python2 > (ideally, it could be portable Python 2 or 3, but it's not so easy to > do), but that would be strange to force even non-git-multimail-users to > use Python2 for that. FWIW,

Re: [PATCH] Standardize python shebangs

2014-05-08 Thread Matthieu Moy
James Denholm writes: > On 8 May 2014 06:57:13 GMT+10:00, Matthieu Moy > wrote: >>Felipe Contreras writes: >> >>> Matthieu Moy wrote: Felipe Contreras writes: > If you want to use python2, then use '/usr/bin/env python2'. Err, yes, this is what the code does before your p

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread James Denholm
On 8 May 2014 06:57:13 GMT+10:00, Matthieu Moy wrote: >Felipe Contreras writes: > >> Matthieu Moy wrote: >>> Felipe Contreras writes: >>> > If you want to use python2, then use '/usr/bin/env python2'. >>> >>> Err, yes, this is what the code does before your patch. >> >> Not for all the instanc

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Matthieu Moy
Felipe Contreras writes: > Matthieu Moy wrote: >> Felipe Contreras writes: >> > If you want to use python2, then use '/usr/bin/env python2'. >> >> Err, yes, this is what the code does before your patch. > > Not for all the instances. Well, I guess not all scripts require python2, hence not all

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Felipe Contreras
Matthieu Moy wrote: > Felipe Contreras writes: > > If you want to use python2, then use '/usr/bin/env python2'. > > Err, yes, this is what the code does before your patch. Not for all the instances. > > If you are going to follow practices different than git.git, then > > multimail shouldn't li

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Matthieu Moy
Felipe Contreras writes: > Matthieu Moy wrote: >> Felipe Contreras writes: >> >> > It's better if all our scripts use the same '/usr/bin/env python'. >> >> Why? >> >> Using python2 for git_multimail.py is a deliberate decision: > > If you want to use python2, then use '/usr/bin/env python2'.

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Felipe Contreras
Matthieu Moy wrote: > Felipe Contreras writes: > > > It's better if all our scripts use the same '/usr/bin/env python'. > > Why? > > Using python2 for git_multimail.py is a deliberate decision: If you want to use python2, then use '/usr/bin/env python2'. > "The git-multimail project itself is

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Matthieu Moy
Felipe Contreras writes: > It's better if all our scripts use the same '/usr/bin/env python'. Why? Using python2 for git_multimail.py is a deliberate decision: https://github.com/mhagger/git-multimail/pull/2 (also, contrib/hooks/multimail/README says: "The git-multimail project itself is cur

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Johan Herland
On Wed, May 7, 2014 at 1:11 PM, Felipe Contreras wrote: > Johan Herland wrote: >> On Wed, May 7, 2014 at 12:03 PM, Felipe Contreras >> wrote: >> > It's better if all our scripts use the same '/usr/bin/env python'. >> >> Only if they are source compatible with both Python2 and Python3. See >> PEP3

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread James Denholm
On 7 May 2014 21:11:53 GMT+10:00, Felipe Contreras wrote: >Johan Herland wrote: >> On Wed, May 7, 2014 at 12:03 PM, Felipe Contreras >> wrote: >> > It's better if all our scripts use the same '/usr/bin/env python'. >> >> Only if they are source compatible with both Python2 and Python3. See >> P

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Felipe Contreras
Johan Herland wrote: > On Wed, May 7, 2014 at 12:03 PM, Felipe Contreras > wrote: > > It's better if all our scripts use the same '/usr/bin/env python'. > > Only if they are source compatible with both Python2 and Python3. See > PEP394 http://legacy.python.org/dev/peps/pep-0394/ >. Otherwise > (f

Re: [PATCH] Standardize python shebangs

2014-05-07 Thread Johan Herland
On Wed, May 7, 2014 at 12:03 PM, Felipe Contreras wrote: > It's better if all our scripts use the same '/usr/bin/env python'. Only if they are source compatible with both Python2 and Python3. See PEP394 http://legacy.python.org/dev/peps/pep-0394/ >. Otherwise (for python2-only scripts) '/usr/bin/

[PATCH] Standardize python shebangs

2014-05-07 Thread Felipe Contreras
It's better if all our scripts use the same '/usr/bin/env python'. Signed-off-by: Felipe Contreras --- contrib/hooks/multimail/README | 6 +++--- contrib/hooks/multimail/git_multimail.py| 2 +- contrib/hooks/multimail/migrate-mailhook-config | 2 +- contrib/hooks/multima