Re: [PATCH] archive: let remote clients get reachable commits

2013-02-22 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 22, 2013 at 10:06:56AM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > How are you proposing to verify master~12 in that example? Because >> > during parsing, it starts with "master", and we remember that? >> >> By not cheating (i.e. using get_sha1()

Re: [PATCH] archive: let remote clients get reachable commits

2013-02-22 Thread Jeff King
On Fri, Feb 22, 2013 at 10:06:56AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > How are you proposing to verify master~12 in that example? Because > > during parsing, it starts with "master", and we remember that? > > By not cheating (i.e. using get_sha1()), but making sure you can >

Re: [PATCH] archive: let remote clients get reachable commits

2013-02-22 Thread Junio C Hamano
Jeff King writes: > How are you proposing to verify master~12 in that example? Because > during parsing, it starts with "master", and we remember that? By not cheating (i.e. using get_sha1()), but making sure you can parse "master" and the adornment on it "~12" is something sane. That is why I

Re: [PATCH] archive: let remote clients get reachable commits

2013-02-22 Thread Jeff King
On Fri, Feb 22, 2013 at 09:10:46AM -0800, Junio C Hamano wrote: > I personally think that it is OK to limit the scope to expressions > that start from the tip of ref and expressions that start with the > SHA-1 at the tip of ref, e.g. > > master~12:Documentation > v2.6.11:arch/alpha >

Re: [PATCH] archive: let remote clients get reachable commits

2013-02-22 Thread Junio C Hamano
Sergey Sergeev writes: [jc: please do not top-post] > You are right, > I'll rethink this patch and write some test for this cases. Thanks. Note that this is harder to implement than one would naïvely think, if one aims for a very generic solution, without walking the whole history. I personal

Re: [PATCH] archive: let remote clients get reachable commits

2013-02-21 Thread Jeff King
On Thu, Feb 21, 2013 at 06:24:03PM +0400, Sergey Segeev wrote: > Some time we need to get valid commit without a ref but with proper > tree-ish, now we can't do that. > > This patch allow upload-archive's to use reachability checking > rather than checking that is a ref. This means a remote clien

[PATCH] archive: let remote clients get reachable commits

2013-02-21 Thread Sergey Segeev
Some time we need to get valid commit without a ref but with proper tree-ish, now we can't do that. This patch allow upload-archive's to use reachability checking rather than checking that is a ref. This means a remote client can fetch a tip of any valid sha1 or tree-ish. --- archive.c