Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Junio C Hamano
Jonathan Nieder writes: > I don't believe the force_mode without an 'x' provides a clear signal > to the end user. Perhaps you meant %cx? Indeed you are right. I think I saw Ramsay's v2 that has the 'x', so let's use that version. Thanks.

Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Ramsay Jones
On 08/08/17 22:45, René Scharfe wrote: > Am 08.08.2017 um 23:36 schrieb Ramsay Jones: >> >> Signed-off-by: Ramsay Jones >> --- >> >> Hi Junio, >> >> I noticed this while looking into the t3700 failure on cygwin tonight. >> Also, I couldn't decide whether or not to add the i18n '_()' brackets >>

Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Jonathan Nieder
Ramsay Jones wrote: > Signed-off-by: Ramsay Jones Reviewed-by: Jonathan Nieder Thanks for catching it.

Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Jonathan Nieder
Junio C Hamano wrote: > René Scharfe writes: >>> diff --git a/builtin/add.c b/builtin/add.c >>> index e888fb8c5..385b53ae7 100644 >>> --- a/builtin/add.c >>> +++ b/builtin/add.c >>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int >>> force_mode) >>>

Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Junio C Hamano
René Scharfe writes: >> diff --git a/builtin/add.c b/builtin/add.c >> index e888fb8c5..385b53ae7 100644 >> --- a/builtin/add.c >> +++ b/builtin/add.c >> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int >> force_mode) >> continue; >> >>

Re: [PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread René Scharfe
Am 08.08.2017 um 23:36 schrieb Ramsay Jones: > > Signed-off-by: Ramsay Jones > --- > > Hi Junio, > > I noticed this while looking into the t3700 failure on cygwin tonight. > Also, I couldn't decide whether or not to add the i18n '_()' brackets > around the message. In the end I didn't, but will

[PATCH] builtin/add: add a missing newline to an stderr message

2017-08-08 Thread Ramsay Jones
Signed-off-by: Ramsay Jones --- Hi Junio, I noticed this while looking into the t3700 failure on cygwin tonight. Also, I couldn't decide whether or not to add the i18n '_()' brackets around the message. In the end I didn't, but will happily add them if you think I should. Thanks! ATB, Ramsay