Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-11 Thread Zoltan Klinger
>> Use git clean --force --force to delete all untracked git repositories > > But I am not sure if this is ever sane. Especially the one that > removes an embedded repository is suspicious. "git clean" should > not ever touch it with or without --superforce or any other command. My original inte

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-10 Thread Junio C Hamano
Soren Brinkmann writes: > But either > way, the output of git clean should match what it is doing. And at least tell > me > if it didn't remove certain dirs or files. Oh, no question about that part. I was reacting to --force --force in general, and an unrelated git repository inside a working

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-10 Thread Soren Brinkmann
On Mon, Dec 10, 2012 at 10:03:28AM -0800, Junio C Hamano wrote: > Soren Brinkmann writes: > > >> > Use git clean --force --force to delete all untracked git repositories > >> > >> But I am not sure if this is ever sane. Especially the one that > >> removes an embedded repository is suspicious.

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-10 Thread Junio C Hamano
Soren Brinkmann writes: >> > Use git clean --force --force to delete all untracked git repositories >> >> But I am not sure if this is ever sane. Especially the one that >> removes an embedded repository is suspicious. "git clean" should >> not ever touch it with or without --superforce or any

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-10 Thread Soren Brinkmann
Hi, On Sun, Dec 09, 2012 at 11:04:59PM -0800, Junio C Hamano wrote: > Zoltan Klinger writes: > > > Would like to get some more feedback on the proposed output in case of > > (1) an untracked subdirectory with multiple files where at least one of > > them > > cannot be removed. > > (2) r

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-10 Thread Soren Brinkmann
Hi Zoltan, On Sun, Dec 09, 2012 at 10:18:19PM +1100, Zoltan Klinger wrote: > >> Hrm, following your discussion (ellided above), I would have > >> expected that you would show > >> > >> Removing directory foo/bar > >> Removing untracked_file1 > > > > Also it would be nice to have warnings a

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-09 Thread Junio C Hamano
Zoltan Klinger writes: > Would like to get some more feedback on the proposed output in case of > (1) an untracked subdirectory with multiple files where at least one of them > cannot be removed. > (2) reporting ignored untracked git subdirectories > > Suppose we have a repo like the one b

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-09 Thread Zoltan Klinger
>> Hrm, following your discussion (ellided above), I would have >> expected that you would show >> >> Removing directory foo/bar >> Removing untracked_file1 > > Also it would be nice to have warnings about undeleted directories since this > git > clean behavior (or the work around to pass

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-06 Thread Soren Brinkmann
Hi, On Thu, Dec 06, 2012 at 09:37:31AM -0800, Junio C Hamano wrote: > Zoltan Klinger writes: > > > Only print out the names of the files and directories that got actually > > deleted. > > > > Consider the following repo layout: > > |-- test.git/ > > |-- foo/ > > |-- bar/ >

Re: [PATCH] git-clean: Display more accurate delete messages

2012-12-06 Thread Junio C Hamano
Zoltan Klinger writes: > Only print out the names of the files and directories that got actually > deleted. > > Consider the following repo layout: > |-- test.git/ > |-- foo/ > |-- bar/ > |-- bar.txt > |-- frotz.git/ > |-- fr

[PATCH] git-clean: Display more accurate delete messages

2012-12-06 Thread Zoltan Klinger
Only print out the names of the files and directories that got actually deleted. Consider the following repo layout: |-- test.git/ |-- foo/ |-- bar/ |-- bar.txt |-- frotz.git/ |-- frotz.txt |-- tracked_file1 |-