Re: [PATCH] pkt-line: Fix sparse errors and warnings

2013-02-26 Thread Ramsay Jones
Jeff King wrote: > On Sat, Feb 23, 2013 at 05:31:34PM -0500, Jeff King wrote: > >> On Sat, Feb 23, 2013 at 06:44:04PM +, Ramsay Jones wrote: >> >>> Sparse issues the following error and warnings: >>> >>> pkt-line.c:209:51: warning: Using plain integer as NULL pointer >>> sideband.c:41:

Re: [PATCH] pkt-line: Fix sparse errors and warnings

2013-02-26 Thread Ramsay Jones
Jeff King wrote: > Thanks for the report. Clearly I should start running "make sparse" more > often (the reason I don't is that it produces dozens of complaints about > constants in /usr/include/bits/xopen_lim.h, which I could obviously care > less about; I should look into suppressing that). Hmm,

Re: [PATCH] pkt-line: Fix sparse errors and warnings

2013-02-24 Thread Junio C Hamano
Jeff King writes: >> Oddly, you seemed to miss the one in connect.c (which my sparse does >> detect). > > Ah, I saw why as soon as I finished off the rebase: that (NULL, 0) goes > away in the very next patch,... Yeah, I noticed that myself while replacing 15. The patch in the message I am respo

Re: [PATCH] pkt-line: Fix sparse errors and warnings

2013-02-23 Thread Jeff King
On Sat, Feb 23, 2013 at 05:31:34PM -0500, Jeff King wrote: > On Sat, Feb 23, 2013 at 06:44:04PM +, Ramsay Jones wrote: > > > Sparse issues the following error and warnings: > > > > pkt-line.c:209:51: warning: Using plain integer as NULL pointer > > sideband.c:41:52: warning: Using pl

Re: [PATCH] pkt-line: Fix sparse errors and warnings

2013-02-23 Thread Jeff King
On Sat, Feb 23, 2013 at 06:44:04PM +, Ramsay Jones wrote: > Sparse issues the following error and warnings: > > pkt-line.c:209:51: warning: Using plain integer as NULL pointer > sideband.c:41:52: warning: Using plain integer as NULL pointer > daemon.c:615:39: warning: Using plain

[PATCH] pkt-line: Fix sparse errors and warnings

2013-02-23 Thread Ramsay Jones
Sparse issues the following error and warnings: pkt-line.c:209:51: warning: Using plain integer as NULL pointer sideband.c:41:52: warning: Using plain integer as NULL pointer daemon.c:615:39: warning: Using plain integer as NULL pointer remote-curl.c:220:75: error: incompatible ty