Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Hi Junio, On Mon, 15 Aug 2016, Junio C Hamano wrote: > Obviously (1) is a lot of impact with little gain, and as Jacob > already offered to do, I think (2) is a lot more sensible solution > and it also is more in line with your "If it isn't broken, do not > fix it", I would say. Yep, that makes

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Johannes Schindelin writes: > On Sun, 14 Aug 2016, Junio C Hamano wrote: > >> Johannes Schindelin writes: >> >> > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') >> > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') >> ...

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Hi Junio, On Sun, 14 Aug 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') > > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') > > The existing sed scriptlet says "we cannot have slash

Re: [PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

Johannes Schindelin writes: > - test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g') > + test=$(echo "$cmd" | sed -e 's|[/ ][/ ]*|_|g' -e 'y/>/_/') The existing sed scriptlet says "we cannot have slash and do not want to have space in filename, so we squash runs of

[PATCH] squash! diff: add --diff-line-prefix option for passing in a prefix

The '>' character is not a legal part of filenames on Windows. So let's just not use it in Git's source code. This poses a challenge in the test script t4013 which distills command-lines into file names (so that the expected outcome can be stored in files with said names). We have to take