Re: [PATCH] transport-helper: check when helpers fail

2012-10-22 Thread Felipe Contreras
On Mon, Oct 22, 2012 at 7:12 PM, Felipe Contreras wrote: > On Mon, Oct 22, 2012 at 4:31 PM, Felipe Contreras > I've tried everything, and yet a SIGPIPE is detected only with > remote-testgit, not with my code, and they both exit the same way, and > at the same time, and fast-export exits the main

Re: [PATCH] transport-helper: check when helpers fail

2012-10-22 Thread Felipe Contreras
On Mon, Oct 22, 2012 at 4:31 PM, Felipe Contreras wrote: > -> import-begin > <- feature X > <- feature Y > -> import refs/heads/master > <- exported stuff > -> import refs/heads/devel > <- exported stuff > -> import-end > <- done > > This would certainly makes things easier for transport-helpers

Re: [PATCH] transport-helper: check when helpers fail

2012-10-22 Thread Felipe Contreras
On Mon, Oct 22, 2012 at 3:46 PM, Johannes Sixt wrote: > Am 10/22/2012 13:50, schrieb Felipe Contreras: >> On Mon, Oct 22, 2012 at 8:35 AM, Johannes Sixt wrote: >>> Another thought: In your use-case, isn't it so that it would be an error >>> that the process exited for whatever reason? I.e., even

Re: [PATCH] transport-helper: check when helpers fail

2012-10-22 Thread Johannes Sixt
Am 10/22/2012 13:50, schrieb Felipe Contreras: > On Mon, Oct 22, 2012 at 8:35 AM, Johannes Sixt wrote: >> Another thought: In your use-case, isn't it so that it would be an error >> that the process exited for whatever reason? I.e., even if it exited with >> code 0 ("success"), it would be an erro

Re: [PATCH] transport-helper: check when helpers fail

2012-10-22 Thread Felipe Contreras
On Mon, Oct 22, 2012 at 8:35 AM, Johannes Sixt wrote: > Am 10/21/2012 21:19, schrieb Felipe Contreras: > I would expect the function to be usable in this way: > > start_command(&proc); > > loop { > if (check_command(&proc)) > break; >

Re: [PATCH] transport-helper: check when helpers fail

2012-10-21 Thread Johannes Sixt
Am 10/21/2012 21:19, schrieb Felipe Contreras: > diff --git a/run-command.c b/run-command.c > index 1101ef7..2852e9d 100644 > --- a/run-command.c > +++ b/run-command.c > @@ -559,6 +559,23 @@ int run_command(struct child_process *cmd) > return finish_command(cmd); > } > > +int check_command

Re: [PATCH] transport-helper: check when helpers fail

2012-10-21 Thread Felipe Contreras
On Sun, Oct 21, 2012 at 10:33 PM, Junio C Hamano wrote: > Felipe Contreras writes: >> +int check_command(struct child_process *cmd) >> +{ >> + int status; >> + pid_t pid; >> + >> + pid = waitpid(cmd->pid, &status, WNOHANG); >> + >> + if (pid < 0) >> + return -1; >> +

Re: [PATCH] transport-helper: check when helpers fail

2012-10-21 Thread Junio C Hamano
Felipe Contreras writes: > Otherwise transport-helper will continue checking for refs and other > things what will confuse the user more. > > Signed-off-by: Felipe Contreras > --- > git-remote-testgit.py | 3 +++ > run-command.c | 17 + > run-command.h

[PATCH] transport-helper: check when helpers fail

2012-10-21 Thread Felipe Contreras
Otherwise transport-helper will continue checking for refs and other things what will confuse the user more. Signed-off-by: Felipe Contreras --- git-remote-testgit.py | 3 +++ run-command.c | 17 + run-command.h | 1 + t/t5800-remote-helpers.sh | 6