Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Junio C Hamano 
Matthieu Moy  writes:

> Patches 1/14 are
>
> Reviewed-by: Matthieu Moy 
>
> On a side note, reviewing patches by batches of 14 patches actually
> turns out to be much less convenient for me than reviewing larger
> batches.
>
> If I'm counting correctly, there should be around 100 patches remaining.
> I'd suggest that the next batch contain them all (probably publishing
> the branch somewhere and posting a merge request here would be better to
> avoid sending 100 mails).

I eyeballed these 28 patches so far (but not this round yet) and
each of the batches did fit my attention span for a series while
looking at other topics also in flight.  Tastes and preferences
differ between us, I guess.

I however can, and am very inclined to, trust your review blindly
and apply further patches on this topic with your Reviewed-by:
without even looking at the patches myself.  If "give us the whole"
is more convenient for you, I am perfectly happy with that approach.

Thanks for reviewing.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Matthieu Moy 
Patches 1/14 are

Reviewed-by: Matthieu Moy 

On a side note, reviewing patches by batches of 14 patches actually
turns out to be much less convenient for me than reviewing larger
batches.

If I'm counting correctly, there should be around 100 patches remaining.
I'd suggest that the next batch contain them all (probably publishing
the branch somewhere and posting a merge request here would be better to
avoid sending 100 mails).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 01/14] t3905-stash-include-untracked.sh: use the $( ... ) construct for command substitution

2014-04-30 Thread Elia Pinto 
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.

The backquoted form is the traditional method for command
substitution, and is supported by POSIX.  However, all but the
simplest uses become complicated quickly.  In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.

The patch was generated by:

for _f in $(find . -name "*.sh")
do
   sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done

and then carefully proof-read.

Signed-off-by: Elia Pinto 
---
 t/t3905-stash-include-untracked.sh |4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/t/t3905-stash-include-untracked.sh 
b/t/t3905-stash-include-untracked.sh
index a5e7e6b..f372fc8 100755
--- a/t/t3905-stash-include-untracked.sh
+++ b/t/t3905-stash-include-untracked.sh
@@ -96,8 +96,8 @@ test_expect_success 'stash pop after save --include-untracked 
leaves files untra
git stash pop &&
git status --porcelain >actual &&
test_cmp expect actual &&
-   test "1" = "`cat file2`" &&
-   test untracked = "`cat untracked/untracked`"
+   test "1" = "$(cat file2)" &&
+   test untracked = "$(cat untracked/untracked)"
 '
 
 git clean --force --quiet -d
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html