Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

Matthieu Moy writes: > Junio C Hamano writes: > >> "brian m. carlson" writes: >> CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \ -e 's/^Signed-off-by: \(.*\)/\1,/gp'` >>> >>> It looks like you may have missed a usage here due to the line break. >> >> Good e

Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

Junio C Hamano writes: > "brian m. carlson" writes: > >>> CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \ >>> -e 's/^Signed-off-by: \(.*\)/\1,/gp'` >> >> It looks like you may have missed a usage here due to the line break. > > Good eyes ;-) > > The following may be

Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

"brian m. carlson" writes: >> CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \ >> -e 's/^Signed-off-by: \(.*\)/\1,/gp'` > > It looks like you may have missed a usage here due to the line break. Good eyes ;-) The following may be an obvious replacement patch, but alt

Re: [PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

On Wed, Apr 23, 2014 at 06:43:56AM -0700, Elia Pinto wrote: > @@ -25,11 +25,11 @@ fi > > cd - > /dev/null > > -SUBJECT=`sed -n -e '/^Subject: /p' "${PATCH}"` > -HEADERS=`sed -e '/^'"${SEP}"'$/,$d' $1` > -BODY=`sed -e "1,/${SEP}/d" $1` > -CMT_MSG=`sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}"` >

[PATCH 04/14] appp.sh: use the $( ... ) construct for command substitution

The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, em