Re: [PATCH 05/15] get_ref_map(): rename local variables

2013-10-24 Thread Michael Haggerty
On 10/23/2013 08:45 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Rename "refs" -> "refspecs" and "ref_count" -> "refspec_count" to >> reduce confusion, because they describe an array of "struct refspec", >> as opposed to the "struct ref" objects that are also used in this >> function

Re: [PATCH 05/15] get_ref_map(): rename local variables

2013-10-23 Thread Junio C Hamano
Michael Haggerty writes: > Rename "refs" -> "refspecs" and "ref_count" -> "refspec_count" to > reduce confusion, because they describe an array of "struct refspec", > as opposed to the "struct ref" objects that are also used in this > function. Good. In general, we'd prefer to name an array of

[PATCH 05/15] get_ref_map(): rename local variables

2013-10-23 Thread Michael Haggerty
Rename "refs" -> "refspecs" and "ref_count" -> "refspec_count" to reduce confusion, because they describe an array of "struct refspec", as opposed to the "struct ref" objects that are also used in this function. Signed-off-by: Michael Haggerty --- builtin/fetch.c | 12 ++-- 1 file change