Re: [PATCH 1/2] help: introduce option --command-only

2016-08-24 Thread Johannes Schindelin
Hi Ralf, On Tue, 23 Aug 2016, Ralf Thielow wrote: > 2016-08-19 10:32 GMT+02:00 Johannes Schindelin : > > > So how about fixing that? I would suggest to do it this way: > > > > - configure help.format = html (for "man", the current code would always > > add

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-23 Thread Ralf Thielow
2016-08-19 10:32 GMT+02:00 Johannes Schindelin : > So how about fixing that? I would suggest to do it this way: > > - configure help.format = html (for "man", the current code would always > add $(prefix)/share/man to the MANPATH when testing, not what we want, >

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-23 Thread Ralf Thielow
2016-08-19 10:39 GMT+02:00 Remi Galan Alfonso : > Hi Ralf, > > Ralf Thielow writes: >> [...] >> +test_expect_success "works for commands and guides by default" " >> +git help status && >> +git help revisions >> +"

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-19 Thread Junio C Hamano
Johannes Schindelin writes: > - configure help.format = html (for "man", the current code would always > add $(prefix)/share/man to the MANPATH when testing, not what we want, > and hacking this code *just* for testing is both ugly and unnecessary). A very

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-19 Thread Johannes Schindelin
Hi Ralf, On Thu, 18 Aug 2016, Ralf Thielow wrote: > diff --git a/t/t0012-help.sh b/t/t0012-help.sh > new file mode 100755 > index 000..e20f907 > --- /dev/null > +++ b/t/t0012-help.sh > @@ -0,0 +1,21 @@ > +#!/bin/sh > + > +test_description='help' > + > +. ./test-lib.sh > + >

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-19 Thread Remi Galan Alfonso
Hi Ralf, Ralf Thielow writes: > [...] > +test_expect_success "works for commands and guides by default" " > +git help status && > +git help revisions > +" > + > +test_expect_success "--command-only does not work for guides" " > +git help

Re: [PATCH 1/2] help: introduce option --command-only

2016-08-18 Thread Philip Oakley
From: "Ralf Thielow" Introduce option --command-only to the help command. With this option being passed, "git help" will open man pages only for commands. Since we know it is a command, we can use function help_unknown_command to give the user advice on typos.

[PATCH 1/2] help: introduce option --command-only

2016-08-18 Thread Ralf Thielow
Introduce option --command-only to the help command. With this option being passed, "git help" will open man pages only for commands. Since we know it is a command, we can use function help_unknown_command to give the user advice on typos. Signed-off-by: Ralf Thielow