Re: [PATCH 1/4] remote-hg: add missing config for basic tests
On Tue, Nov 13, 2012 at 04:46:36AM +0100, Felipe Contreras wrote:
> >> +setup () {
> >> + (
> >> + echo "[ui]"
> >> + echo "username = A U Thor "
> >> + ) >> "$HOME"/.hgrc
> >> +}
> >
> > This makes sense, but I wonder if we should use something different from
> > the git author ident set up by the test scripts, just to double check
> > that we do not have any bugs in confusing the two during the import.
>
> I don't know, but these tests would not check for any of those issues.
> When such tests are added I would prefer the author to use to be
> explicitly defined, but lets see.
It's OK if we do not add more explicit tests at this point. I'd just
rather set a safer precedent on the off chance that it might catch
something in a later test, just as we use separate GIT_AUTHOR_* and
GIT_COMMITTER_* in the rest of the test suite. If the choice were not
completely arbitrary and had some maintenance cost, I might be more
concerned, but as far as I can tell, one name is as good as another at
this point.
Any objection to me marking it up as I apply?
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] remote-hg: add missing config for basic tests
On Mon, Nov 12, 2012 at 9:32 PM, Jeff King wrote:
> On Mon, Nov 12, 2012 at 06:41:05PM +0100, Felipe Contreras wrote:
>
>> From: Ramkumar Ramachandra
>>
>> 'hg commit' fails otherwise in some versiosn of mercurial because of
>
> s/versiosn/versions/
>
>> +setup () {
>> + (
>> + echo "[ui]"
>> + echo "username = A U Thor "
>> + ) >> "$HOME"/.hgrc
>> +}
>
> This makes sense, but I wonder if we should use something different from
> the git author ident set up by the test scripts, just to double check
> that we do not have any bugs in confusing the two during the import.
I don't know, but these tests would not check for any of those issues.
When such tests are added I would prefer the author to use to be
explicitly defined, but lets see.
--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 1/4] remote-hg: add missing config for basic tests
On Mon, Nov 12, 2012 at 06:41:05PM +0100, Felipe Contreras wrote:
> From: Ramkumar Ramachandra
>
> 'hg commit' fails otherwise in some versiosn of mercurial because of
s/versiosn/versions/
> +setup () {
> + (
> + echo "[ui]"
> + echo "username = A U Thor "
> + ) >> "$HOME"/.hgrc
> +}
This makes sense, but I wonder if we should use something different from
the git author ident set up by the test scripts, just to double check
that we do not have any bugs in confusing the two during the import.
Something like "H G Wells " would work, and satisfies
my deep-seated desire for bad puns.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 1/4] remote-hg: add missing config for basic tests
From: Ramkumar Ramachandra
'hg commit' fails otherwise in some versiosn of mercurial because of
the missing user information. Other versions simply throw a warning and
guess though.
Signed-off-by: Ramkumar Ramachandra
Signed-off-by: Felipe Contreras
---
contrib/remote-helpers/test-hg.sh | 9 +
1 file changed, 9 insertions(+)
diff --git a/contrib/remote-helpers/test-hg.sh
b/contrib/remote-helpers/test-hg.sh
index 40e6e3c..031dcbd 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -29,6 +29,15 @@ check () {
test_cmp expected actual
}
+setup () {
+ (
+ echo "[ui]"
+ echo "username = A U Thor "
+ ) >> "$HOME"/.hgrc
+}
+
+setup
+
test_expect_success 'cloning' '
test_when_finished "rm -rf gitrepo*" &&
--
1.8.0
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
