Re: [PATCH 13/26] update-ref --stdin: Simplify error messages for missing oldvalues

2014-03-10 Thread Brad King
On 03/10/2014 08:46 AM, Michael Haggerty wrote: > Instead of, for example, > > fatal: update refs/heads/master missing [] NUL > > emit > > fatal: update refs/heads/master missing [snip] > - die("update %s missing [] NUL", update->ref_name); > + die("update %s mis

Re: [PATCH 13/26] update-ref --stdin: Simplify error messages for missing oldvalues

2014-03-10 Thread Brad King
On 03/10/2014 01:08 PM, Brad King wrote: >> -die("update %s missing [] NUL", update->ref_name); >> +die("update %s missing ", update->ref_name); > > The reason for the original wording is that the is indeed > optional. This can only occur at end-of-input, and it is actual

[PATCH 13/26] update-ref --stdin: Simplify error messages for missing oldvalues

2014-03-10 Thread Michael Haggerty
Instead of, for example, fatal: update refs/heads/master missing [] NUL emit fatal: update refs/heads/master missing Update the tests accordingly. Signed-off-by: Michael Haggerty --- builtin/update-ref.c | 6 +++--- t/t1400-update-ref.sh | 6 +++--- 2 files changed, 6 insertions(+)