Re: [PATCH 2/2] commit-graph: turn off save_commit_buffer

2019-09-08 Thread Jeff King
On Sat, Sep 07, 2019 at 02:56:36PM -0400, Taylor Blau wrote: > So, the patch here looks obviously correct, and I don't think it needs a > test or anything like that... besides: what is there to test? :). There's no functional change, so as long as this has coverage in the regular suite (and I thi

Re: [PATCH 2/2] commit-graph: turn off save_commit_buffer

2019-09-07 Thread Taylor Blau
On Sat, Sep 07, 2019 at 01:04:40AM -0400, Jeff King wrote: > The commit-graph tool may read a lot of commits, but it only cares about > parsing their metadata (parents, trees, etc) and doesn't ever show the > messages to the user. And so it should not need save_commit_buffer, > which is meant for h

[PATCH 2/2] commit-graph: turn off save_commit_buffer

2019-09-06 Thread Jeff King
The commit-graph tool may read a lot of commits, but it only cares about parsing their metadata (parents, trees, etc) and doesn't ever show the messages to the user. And so it should not need save_commit_buffer, which is meant for holding onto the object data of parsed commits so that we can show t