Re[4]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-28 Thread Ilya Basin
IB> * I think git-svn doesn't handle the case, when a tag is deleted. IB> I expected it to rename the ref from "tags/tagname" to IB> "tags/tagname@rev", but that doesn't happen. IB> If a tag is replaced, there's no way to tell what was the previous IB> state of that tag: git-svn just rewrit

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-08 Thread Eric Wong
Ilya Basin wrote: > Hi Eric. I'm out of spare time and I still unable to import my repo. > The code of SVN.pm is too complex. Please help me. Sorry, most what I do nowadays for git-svn is ACK/NACK changes. git-svn has made itself obsolete for most contributors, myself included; so it's hard for

Re[3]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-06 Thread Ilya Basin
Hi Eric. I'm out of spare time and I still unable to import my repo. The code of SVN.pm is too complex. Please help me. Here's the list of my issues: * I think git-svn doesn't handle the case, when a tag is deleted. I expected it to rename the ref from "tags/tagname" to "tags/tagname@rev", but

Re[4]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-06 Thread Ilya Basin
The last error I encountered is: r7009 = 39805bb078983e34f2fc8d2c8c02d695d00d11c0 (refs/remotes/DMC4_Basic) Too many open files: Can't open file '/home/il/builds/sicap/gitsvn/prd_dmc4.svn/db/revs/0/786': Too many open files at /.snapshots/persist/builds/git/git-git/

Re[3]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Ilya Basin
EW>> Ilya Basin wrote: >>> Hi. I won't send you updated patches until I import and test my huge >>> repo. Everything will be here: >>> https://github.com/basinilya/git/commits/v1.8.2.2-git-svn-fixes >>> >>> At the moment I've decided not to implement the Junio's proposal: >>> > >> JCH> comment li

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Ilya Basin
EW> Ilya Basin wrote: >> Hi. I won't send you updated patches until I import and test my huge >> repo. Everything will be here: >> https://github.com/basinilya/git/commits/v1.8.2.2-git-svn-fixes >> >> At the moment I've decided not to implement the Junio's proposal: >> > >> JCH> comment line "# a

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Eric Wong
Ilya Basin wrote: > Hi. I won't send you updated patches until I import and test my huge > repo. Everything will be here: > https://github.com/basinilya/git/commits/v1.8.2.2-git-svn-fixes > > At the moment I've decided not to implement the Junio's proposal: > > >> JCH> comment line "# added by gi

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Eric Wong
Ilya Basin wrote: > EW> My personal philosophy has always been: git svn users should leave > EW> no trace or indication they're using a non-standard SVN client. > > Placeholders aren't pushed back to svn. Right, I was confused, as I often am :x -- To unsubscribe from this list: send the line "un

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Ray Chen
On Wed, May 1, 2013 at 10:49 PM, Eric Wong wrote: > Junio C Hamano wrote: > >> Eric Wong writes: > >> That however is not a property of the directory containing it (or >> the path to that .gitignore file) that is valid throughout the >> history of the project. It is a property of a specific tre

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Ilya Basin
Hi. I won't send you updated patches until I import and test my huge repo. Everything will be here: https://github.com/basinilya/git/commits/v1.8.2.2-git-svn-fixes At the moment I've decided not to implement the Junio's proposal: > >> JCH> comment line "# added by git-svn only to keep the director

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Ilya Basin
EW> My personal philosophy has always been: git svn users should leave EW> no trace or indication they're using a non-standard SVN client. Placeholders aren't pushed back to svn. -- -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kerne

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > Ilya Basin wrote: > >> JCH> comment line "# added by git-svn only to keep the directory" and > >> JCH> consider a directory that has nothing but .gitignore that consists > >> JCH> of only that exact comment line an "added placeholder" directory to >

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Junio C Hamano
Eric Wong writes: > Ilya Basin wrote: >> JCH> comment line "# added by git-svn only to keep the directory" and >> JCH> consider a directory that has nothing but .gitignore that consists >> JCH> of only that exact comment line an "added placeholder" directory to >> JCH> work it around. >> Sounds

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Eric Wong
Ilya Basin wrote: > JCH> comment line "# added by git-svn only to keep the directory" and > JCH> consider a directory that has nothing but .gitignore that consists > JCH> of only that exact comment line an "added placeholder" directory to > JCH> work it around. > Sounds good, but it's not I who de

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Ilya Basin
JCH> ...and you want to perform a merge on the JCH> Git side of that branch with another Git branch that does have real JCH> contents in that directory, you would want the result to say "This JCH> directory no longer is just for a placeholder", but you cannot say JCH> that globally by updating the

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Junio C Hamano
Ilya Basin writes: > IB> In my repo the placeholders change too often (in 1/4 commits). I'm > IB> thinking of using: > IB> 'git config --unset "svn-remote.$repo_id.added-placeholder" path_regex' > IB> instead of full rewrite. > > I need your help. There are still problems: > > $ grep "define

Re[2]: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Ilya Basin
IB> In my repo the placeholders change too often (in 1/4 commits). I'm IB> thinking of using: IB> 'git config --unset "svn-remote.$repo_id.added-placeholder" path_regex' IB> instead of full rewrite. I need your help. There are still problems: $ grep "define MAX_MATCHES" ~/builds/git/git-git/c

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-04-30 Thread Ilya Basin
IB> + return undef if (!keys $self->{_save_ph}); Correct is: return undef if (!keys %{$self->{_save_ph}}); In my repo the placeholders change too often (in 1/4 commits). I'm thinking of using: 'git config --unset "svn-remote.$repo_id.added-placeholder" path_regex' instead of full rewrite. -

[PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-04-30 Thread Ilya Basin
.git/config is written on each commit. It's slow --- perl/Git/SVN/Fetcher.pm | 77 +++-- 1 file changed, 49 insertions(+), 28 deletions(-) diff --git a/perl/Git/SVN/Fetcher.pm b/perl/Git/SVN/Fetcher.pm index e658889..a5ad4cd 100644 --- a/perl/Git/SVN/Fe