Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Junio C Hamano
Erik Faye-Lund kusmab...@gmail.com writes: On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal ka...@ucw.cz wrote: From: Pat Thoyts pattho...@users.sourceforge.net On Windows the application command line is provided as unicode and in mingw-git we convert that to utf-8. So these tests that require

Re: [msysGit] Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Johannes Schindelin
Hi Junio, On Mon, 21 Jul 2014, Junio C Hamano wrote: Oh by the way, can somebody remind me why we spell these as NOT_MINGW, instead of !MINGW? I guess that is my mistake; when I introduced the use of NOT_MINGW I was simply unaware of the !MINGW syntax. Let's use the latter consistently?

Re: [msysGit] Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Johannes Sixt
Am 21.07.2014 19:45, schrieb Johannes Schindelin: Hi Junio, On Mon, 21 Jul 2014, Junio C Hamano wrote: Oh by the way, can somebody remind me why we spell these as NOT_MINGW, instead of !MINGW? I guess that is my mistake; when I introduced the use of NOT_MINGW I was simply unaware of

Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Oh by the way, can somebody remind me why we spell these as NOT_MINGW, instead of !MINGW? Simple answer seems to be that !ANYTHING appeared only at bdccd3c1 (test-lib: allow negation of prerequisites, 2012-11-14) but at that version already 5 test

Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Junio C Hamano gits...@pobox.com writes: Oh by the way, can somebody remind me why we spell these as NOT_MINGW, instead of !MINGW? Simple answer seems to be that !ANYTHING appeared only at bdccd3c1 (test-lib: allow negation of prerequisites,

Re: [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-21 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: So here is the first of the two small/trivial patch series. To prepare the first one, I did git grep -e '\NOT_' t/ to the result of applying Stepan's series and edited the hits manually. And then compared the result with running $ perl -p -i -e

Re: [msysGit] [PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-18 Thread Erik Faye-Lund
On Thu, Jul 17, 2014 at 5:37 PM, Stepan Kasal ka...@ucw.cz wrote: From: Pat Thoyts pattho...@users.sourceforge.net On Windows the application command line is provided as unicode and in mingw-git we convert that to utf-8. So these tests that require a iso-8859-1 input are being subverted by

[PATCH 4/6] t4210: skip command-line encoding tests on mingw

2014-07-17 Thread Stepan Kasal
From: Pat Thoyts pattho...@users.sourceforge.net On Windows the application command line is provided as unicode and in mingw-git we convert that to utf-8. So these tests that require a iso-8859-1 input are being subverted by the encoding transformations we perform and should be skipped.