Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Stefan Beller
It is serious. The purpose of the 'contrib/' area is not clear. The statemens coming from Junio don't match what is on 'contrib/README'. So we have a huge variance of quality all over 'contrib/'. Some tools in contrib have higher quality than what is part of the core (e.g. they have tests,

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Felipe Contreras
Stefan Beller wrote: It is serious. The purpose of the 'contrib/' area is not clear. The statemens coming from Junio don't match what is on 'contrib/README'. So we have a huge variance of quality all over 'contrib/'. Some tools in contrib have higher quality than what is part of the

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Thu, May 08, 2014 at 07:58:30PM -0500, Felipe Contreras wrote: No activity since 2012, no tests, no chance of ever graduating. I don't think no activity is an interesting indicator. This tool _is_ actively maintained, but it has not needed any fixes since

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Felipe Contreras
Junio C Hamano wrote: There is no prove yourself is worthy or get evicted purge going on in the contrib/ area. I saw contrib/README referred to a few times in the near-by threads, and I think these patches are done primarily by deliberately misinterpreting one part of it in order to grab

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: *You* said this[1]: If you read the context you omitted from the quote, and realize that it was a counter-suggestion to give a middle ground to a more draconian let's divide them into two, neither which I said I want to see go forward

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Felipe Contreras
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: *You* said this[1]: If you read the context you omitted from the quote, and realize that it was a counter-suggestion to give a middle ground to a more draconian let's divide them into two, neither which I said I

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: *You* said this[1]: If you read the context you omitted from the quote, and realize that it was a counter-suggestion to give a middle ground to a more draconian

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-09 Thread Felipe Contreras
Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: Junio C Hamano wrote: Felipe Contreras felipe.contre...@gmail.com writes: *You* said this[1]: If you read the context you omitted from the quote, and realize that it was a counter-suggestion to give a

[PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-08 Thread Felipe Contreras
No activity since 2012, no tests, no chance of ever graduating. Cc: Jeff King p...@peff.net Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- contrib/diff-highlight/README | 152 - contrib/diff-highlight/diff-highlight | 173

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-08 Thread Jeff King
On Thu, May 08, 2014 at 07:58:30PM -0500, Felipe Contreras wrote: No activity since 2012, no tests, no chance of ever graduating. I don't think no activity is an interesting indicator. This tool _is_ actively maintained, but it has not needed any fixes since 2012. I use it for every single git

Re: [PATCH v1 19/25] contrib: remove 'diff-highlight'

2014-05-08 Thread Felipe Contreras
Jeff King wrote: On Thu, May 08, 2014 at 07:58:30PM -0500, Felipe Contreras wrote: No activity since 2012, no tests, no chance of ever graduating. I don't think no activity is an interesting indicator. This tool _is_ actively maintained, but it has not needed any fixes since 2012. I use