Re: [PATCH v2 00/20] object_id part 5

2016-09-07 Thread Junio C Hamano
"brian m. carlson" writes: > On Wed, Sep 07, 2016 at 01:12:09PM -0700, Junio C Hamano wrote: >> It is a bit unfortunate that this conflicts somewhat in builtin/cat-file.c >> and heavily with builtin/apply.c with other topics in flight. >> >> Let me see how bad the

Re: [PATCH v2 00/20] object_id part 5

2016-09-07 Thread brian m. carlson
On Wed, Sep 07, 2016 at 01:12:09PM -0700, Junio C Hamano wrote: > It is a bit unfortunate that this conflicts somewhat in builtin/cat-file.c > and heavily with builtin/apply.c with other topics in flight. > > Let me see how bad the conflict resolution is and report back later. If it ends up

Re: [PATCH v2 00/20] object_id part 5

2016-09-07 Thread Junio C Hamano
"brian m. carlson" writes: > This is the fifth in a series of series to convert from unsigned char [20] to > struct object_id. > > This series converts many of the files in the builtin directory to use struct > object_id. This gets us almost to the point where we

[PATCH v2 00/20] object_id part 5

2016-09-05 Thread brian m. carlson
This is the fifth in a series of series to convert from unsigned char [20] to struct object_id. This series converts many of the files in the builtin directory to use struct object_id. This gets us almost to the point where we can convert get_tree_entry to use struct object_id, but not quite.