[PATCH v2 1/3] branch: reject -D/-d without branch name

2013-01-25 Thread Nguyễn Thái Ngọc Duy
--- builtin/branch.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/builtin/branch.c b/builtin/branch.c index 873f624..50fcacc 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -837,9 +837,11 @@ int cmd_branch(int argc, const char **argv, const char *prefix)

Re: [PATCH v2 1/3] branch: reject -D/-d without branch name

2013-01-25 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: --- builtin/branch.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Forgot to sign-off? Is this a real problem? I do not see it particularly wrong to succeed after deleting 0 or more given branch names. diff --git

Re: [PATCH v2 1/3] branch: reject -D/-d without branch name

2013-01-25 Thread Duy Nguyen
On Sat, Jan 26, 2013 at 2:04 AM, Junio C Hamano gits...@pobox.com wrote: Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: --- builtin/branch.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Forgot to sign-off? Yes Is this a real problem? Yes. My thoughts yesterday when I