Ramkumar Ramachandra writes:
> Maybe we should add the
> line "Not for end user interactive use" to both descriptions? We can
> get that double-underscore if you really want, but it'd stick out like
> a sore thumb since we can't change create.
Yeah, good point about the __name.
It was a mistak
Junio C Hamano wrote:
> "create" is not advertised very widely, but "store" is too close to
> what is already familiar to the people "save" and we really do not
> want to confuse them. "store -m message commit" sounds as if you
> are creating a stash to apply to the given $commit.
In the store se
Matthieu Moy writes:
> One benefit would be to avoid triggering rebuild (and editor reload) by
> keeping the timestamps intact. But I agree it's probably not worth the
> effort (and definitely isn't in the scope of this series).
It isn't in the scope, of course. If rebase were done right, the
s
Ramkumar Ramachandra writes:
> Junio C Hamano wrote:
>> Especially I did not check if there are
>> still undesirable data loss behaviour in corner cases that people
>> were worried about in the discussion.
>
> Check the tests. What am I missing?
>
>>In the longer term, it is unmaintainable t
Ramkumar Ramachandra writes:
> Junio C Hamano wrote:
>> Especially I did not check if there are
>> still undesirable data loss behaviour in corner cases that people
>> were worried about in the discussion.
>
> Check the tests. What am I missing?
I didn't do a thorough check, but my earlier comm
Junio C Hamano wrote:
> Especially I did not check if there are
> still undesirable data loss behaviour in corner cases that people
> were worried about in the discussion.
Check the tests. What am I missing?
>In the longer term, it is unmaintainable to make such users (like
>this new cod
Ramkumar Ramachandra writes:
> Minor changes since v2 in response to reviews by Junio and Eric
> Sunshine.
>
> Should be ready to merge soon.
That, and the "completed" on the Subject line are not for you to
decide, I would have to say ;-)
Overall the patches look cleanly done, but I did not car
Minor changes since v2 in response to reviews by Junio and Eric
Sunshine.
Should be ready to merge soon.
Ramkumar Ramachandra (7):
am: tighten a conditional that checks for $dotest
rebase -i: don't error out if $state_dir already exists
rebase: prepare to do generic housekeeping
am: retur
8 matches
Mail list logo
