Re: [PATCH v3 16/17] lib'ify checkout_fast_forward_to()

2016-09-11 Thread Johannes Schindelin
Hi Junio, On Fri, 9 Sep 2016, Junio C Hamano wrote: > Johannes Schindelin writes: > > > Instead of dying there, let the caller high up in the callchain > > notice the error and handle it (by dying, still). > > > > The only callers of checkout_fast_forward_to(),

Re: [PATCH v3 16/17] lib'ify checkout_fast_forward_to()

2016-09-09 Thread Junio C Hamano
Johannes Schindelin writes: > Instead of dying there, let the caller high up in the callchain > notice the error and handle it (by dying, still). > > The only callers of checkout_fast_forward_to(), cmd_merge(), > pull_into_void(), cmd_pull() and sequencer's

[PATCH v3 16/17] lib'ify checkout_fast_forward_to()

2016-09-09 Thread Johannes Schindelin
Instead of dying there, let the caller high up in the callchain notice the error and handle it (by dying, still). The only callers of checkout_fast_forward_to(), cmd_merge(), pull_into_void(), cmd_pull() and sequencer's fast_forward_to(), already check the return value and handle it