Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Caleb Thompson
Jeremiah, That looks great. Since I'm not seeing any more feedback on the code for this set of patches, I'll go ahead and send up another set. Thank you for those pointers. Caleb Thompson On Thu, Jun 12, 2014 at 11:46:37AM -0700, Jeremiah Mahler wrote: > Caleb, > > On Thu, Jun 12, 2014 at 01:23

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Jeremiah Mahler
Caleb, On Thu, Jun 12, 2014 at 01:23:41PM -0500, Caleb Thompson wrote: > Jeremiah, > > On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote: > > ... > > > > How are you preparing your patches. 'git format-patch' with a 'git > > send-email'? > > I'm so glad you asked, because I've jus

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Caleb Thompson
Jeremiah, On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote: > > Thanks for checking. Unfortunately the problem persists for me. > > It seems to be related to there not being a space at the left most part > of the patch. It is just a tab with no space. So 'git am' has a > problem

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Jeremiah Mahler
On Thu, Jun 12, 2014 at 11:04:59AM -0700, Jeremiah Mahler wrote: > Caleb, > ... > > Thanks for checking. Unfortunately the problem persists for me. > > It seems to be related to there not being a space at the left most part > of the patch. It is just a tab with no space. So 'git am' has a > pr

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Jeremiah Mahler
Caleb, On Thu, Jun 12, 2014 at 08:51:31AM -0500, Caleb Thompson wrote: > I assume that you're running it against master? > > I rebased the branch yesterday, but I'll give it another shot. Obviously I > didn't use git-am, but I can try that. > > Caleb Thompson > > On Thu, Jun 12, 2014 at 01:41:5

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Caleb Thompson
I assume that you're running it against master? I rebased the branch yesterday, but I'll give it another shot. Obviously I didn't use git-am, but I can try that. Caleb Thompson On Thu, Jun 12, 2014 at 01:41:52AM -0700, Jeremiah Mahler wrote: > On Wed, Jun 11, 2014 at 01:24:36PM -0500, ca...@cale

Re: [PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-12 Thread Jeremiah Mahler
On Wed, Jun 11, 2014 at 01:24:36PM -0500, ca...@calebthompson.io wrote: > Some of the tests in t/t7507-commit-verbose.sh were still using > git-config to set configuration. Change them to use the test_config > helper. > > Signed-off-by: Caleb Thompson > --- > t/t7507-commit-verbose.sh | 4 ++-- >

[PATCH v4 1/4] commit test: Use test_config instead of git-config

2014-06-11 Thread
Some of the tests in t/t7507-commit-verbose.sh were still using git-config to set configuration. Change them to use the test_config helper. Signed-off-by: Caleb Thompson --- t/t7507-commit-verbose.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/t7507-commit-verbose.s