Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Junio C Hamano writes: >> I think the notice still deserve the "***NOTICE***" or whatever makes it >> visible enough to distinguish it from the traditional licence & >> non-warranty header, but I don't think we should kill the old script too >> early. > > True. I personally felt that Jonathan's (1) read the most natural > (i.e. showing no strong preference, just let the users decide). We need a decider to push this forward, so let's squash this in to tone it down and then merge the result to 'next' (and then 'master' by -rc1). contrib/hooks/post-receive-email | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 23d7783..1531150 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -4,8 +4,8 @@ # # An example hook script to mail out commit update information. # -# ***NOTICE***: This script is no longer under active development. It -# has been superseded by git-multimail, which is more capable and +# NOTE: This script is no longer under active development. There +# is another script, git-multimail, which is more capable and # configurable and is largely backwards-compatible with this script; # please see "contrib/hooks/multimail/". For instructions on how to # migrate from post-receive-email to git-multimail, please see -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Matthieu Moy writes: > Jonathan Nieder writes: > >> (3) >> # An example hook ... >> # >> # Warning: this script is no longer actively maintained. Consider >> # switching to ... >> >> I prefer (2), which makes it clear to the reader that it is dangerous >> to keep using the script (since no one is actively chasing down bugs) >> while also making it clear why a potentially buggy script with a good >> natural successor is still in contrib for now. What do you think? > > I don't think it is dangerous to keep using the old script. If you look > at its history, it's pretty stable these day. I think it has known bugs > in new revision detections that are fixed by git-multimail, but nothing > really blocking IMHO. > > There are two good reasons to use it: 1) you already use it, and you're > too lazy to change (e.g. because it's packaged by Debian and is already > there on your server), and 2) you don't have Python on your server. Well said. > I think the notice still deserve the "***NOTICE***" or whatever makes it > visible enough to distinguish it from the traditional licence & > non-warranty header, but I don't think we should kill the old script too > early. True. I personally felt that Jonathan's (1) read the most natural (i.e. showing no strong preference, just let the users decide). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Jonathan Nieder writes: > (3) > # An example hook ... > # > # Warning: this script is no longer actively maintained. Consider > # switching to ... > > I prefer (2), which makes it clear to the reader that it is dangerous > to keep using the script (since no one is actively chasing down bugs) > while also making it clear why a potentially buggy script with a good > natural successor is still in contrib for now. What do you think? I don't think it is dangerous to keep using the old script. If you look at its history, it's pretty stable these day. I think it has known bugs in new revision detections that are fixed by git-multimail, but nothing really blocking IMHO. There are two good reasons to use it: 1) you already use it, and you're too lazy to change (e.g. because it's packaged by Debian and is already there on your server), and 2) you don't have Python on your server. I think the notice still deserve the "***NOTICE***" or whatever makes it visible enough to distinguish it from the traditional licence & non-warranty header, but I don't think we should kill the old script too early. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
On 07/15/2013 08:02 AM, Jonathan Nieder wrote: > Michael Haggerty wrote: > >> Add a notice to the top of post-receive-email explaining that the >> script is no longer under active development and pointing the user to >> git-multimail. > > I think the spirit of this patch is sane. Some thoughts on wording: > > [...] >> --- a/contrib/hooks/post-receive-email >> +++ b/contrib/hooks/post-receive-email >> @@ -2,10 +2,19 @@ >> # >> # Copyright (c) 2007 Andy Parkins >> # >> -# An example hook script to mail out commit update information. This hook >> -# sends emails listing new revisions to the repository introduced by the >> -# change being reported. The rule is that (for branch updates) each commit >> -# will appear on one email and one email only. >> +# An example hook script to mail out commit update information. >> +# >> +# ***NOTICE***: This script is no longer under active development. It >> +# has been superseded by git-multimail, which is more capable and >> +# configurable and is largely backwards-compatible with this script; >> +# please see "contrib/hooks/multimail/". For instructions on how to >> +# migrate from post-receive-email to git-multimail, please see >> +# "README.migrate-from-post-receive-email" in that directory. > > I think I'd say something like > > (1) > # An example hook script to mail out commit update information. > # > # This script is kept for compatibility, but it is no longer actively > # maintained. Consider switching to git-multimail, which is more > # configurable and largely compatible with this script. See > # contrib/hooks/multimail/README.migrate-from-post-receive. > # > # This hook sends emails listing new revisions ... > > or, if I wanted to emphasize the warning, > > (2) > # An example hook ... > # > # Warning: this script is kept for compatibility, but it is no longer > # actively maintained. Consider switching to ... > > or, if I wanted to avoid seeming to promise that the script will be > around in the future, > > (3) > # An example hook ... > # > # Warning: this script is no longer actively maintained. Consider > # switching to ... > > I prefer (2), which makes it clear to the reader that it is dangerous > to keep using the script (since no one is actively chasing down bugs) > while also making it clear why a potentially buggy script with a good > natural successor is still in contrib for now. What do you think? Honestly, as the main author of git-multimail, I am biased and think it would be better for other people to make the decision about if/how/when to annotate post-receive-email. Any of your suggestions are fine with me. Michael -- Michael Haggerty mhag...@alum.mit.edu http://softwareswirl.blogspot.com/ -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Michael Haggerty wrote: > Add a notice to the top of post-receive-email explaining that the > script is no longer under active development and pointing the user to > git-multimail. I think the spirit of this patch is sane. Some thoughts on wording: [...] > --- a/contrib/hooks/post-receive-email > +++ b/contrib/hooks/post-receive-email > @@ -2,10 +2,19 @@ > # > # Copyright (c) 2007 Andy Parkins > # > -# An example hook script to mail out commit update information. This hook > -# sends emails listing new revisions to the repository introduced by the > -# change being reported. The rule is that (for branch updates) each commit > -# will appear on one email and one email only. > +# An example hook script to mail out commit update information. > +# > +# ***NOTICE***: This script is no longer under active development. It > +# has been superseded by git-multimail, which is more capable and > +# configurable and is largely backwards-compatible with this script; > +# please see "contrib/hooks/multimail/". For instructions on how to > +# migrate from post-receive-email to git-multimail, please see > +# "README.migrate-from-post-receive-email" in that directory. I think I'd say something like (1) # An example hook script to mail out commit update information. # # This script is kept for compatibility, but it is no longer actively # maintained. Consider switching to git-multimail, which is more # configurable and largely compatible with this script. See # contrib/hooks/multimail/README.migrate-from-post-receive. # # This hook sends emails listing new revisions ... or, if I wanted to emphasize the warning, (2) # An example hook ... # # Warning: this script is kept for compatibility, but it is no longer # actively maintained. Consider switching to ... or, if I wanted to avoid seeming to promise that the script will be around in the future, (3) # An example hook ... # # Warning: this script is no longer actively maintained. Consider # switching to ... I prefer (2), which makes it clear to the reader that it is dangerous to keep using the script (since no one is actively chasing down bugs) while also making it clear why a potentially buggy script with a good natural successor is still in contrib for now. What do you think? Thanks, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 2/2] post-receive-email: deprecate script in favor of git-multimail
Add a notice to the top of post-receive-email explaining that the script is no longer under active development and pointing the user to git-multimail. Signed-off-by: Michael Haggerty --- If you think this is premature or the wording is too strong; feel free to change or omit this patch. I think it's fine, but then I might be biased... contrib/hooks/post-receive-email | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/contrib/hooks/post-receive-email b/contrib/hooks/post-receive-email index 0e5b72d..23d7783 100755 --- a/contrib/hooks/post-receive-email +++ b/contrib/hooks/post-receive-email @@ -2,10 +2,19 @@ # # Copyright (c) 2007 Andy Parkins # -# An example hook script to mail out commit update information. This hook -# sends emails listing new revisions to the repository introduced by the -# change being reported. The rule is that (for branch updates) each commit -# will appear on one email and one email only. +# An example hook script to mail out commit update information. +# +# ***NOTICE***: This script is no longer under active development. It +# has been superseded by git-multimail, which is more capable and +# configurable and is largely backwards-compatible with this script; +# please see "contrib/hooks/multimail/". For instructions on how to +# migrate from post-receive-email to git-multimail, please see +# "README.migrate-from-post-receive-email" in that directory. +# +# This hook sends emails listing new revisions to the repository +# introduced by the change being reported. The rule is that (for +# branch updates) each commit will appear on one email and one email +# only. # # This hook is stored in the contrib/hooks directory. Your distribution # will have put this somewhere standard. You should make this script -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
