Re: [PATCH v4 4/5] t4205, t6006: Add failing tests for the case when i18n.logOutputEncoding is set
Ramsay Jones writes: > On 21/05/14 14:20, Alexey Shumkin wrote: >> Pretty format string %<(N,[ml]trunc)>%s truncates subject to a given >> length with an appropriate padding. This works for non-ASCII texts when >> i18n.logOutputEncoding is UTF-8 only (independently of a printed commit >> message encoding) but does not work when i18n.logOutputEncoding is NOT >> UTF-8. >> >> There were no breakages as far as were no tests for the case >> when both a commit message and logOutputEncoding are not UTF-8. >> >> Add failing tests for that which will be fixed in the next patch. >> >> Signed-off-by: Alexey Shumkin >> Reviewed-by: Nguyễn Thái Ngọc Duy >> Reviewed-by: Ramsay Jones > > Hmm, I didn't really review these patches. I simply noted a problem > on my system and provided you with an extended bug-report and > assisted you in fixing it up. So, if it even warrants a mention in > the commit message, then 'Helped-by:' would be nearer the mark. I had the same impression. The same for Duy's. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH v4 4/5] t4205, t6006: Add failing tests for the case when i18n.logOutputEncoding is set
On 21/05/14 14:20, Alexey Shumkin wrote: > Pretty format string %<(N,[ml]trunc)>%s truncates subject to a given > length with an appropriate padding. This works for non-ASCII texts when > i18n.logOutputEncoding is UTF-8 only (independently of a printed commit > message encoding) but does not work when i18n.logOutputEncoding is NOT > UTF-8. > > There were no breakages as far as were no tests for the case > when both a commit message and logOutputEncoding are not UTF-8. > > Add failing tests for that which will be fixed in the next patch. > > Signed-off-by: Alexey Shumkin > Reviewed-by: Nguyễn Thái Ngọc Duy > Reviewed-by: Ramsay Jones Hmm, I didn't really review these patches. I simply noted a problem on my system and provided you with an extended bug-report and assisted you in fixing it up. So, if it even warrants a mention in the commit message, then 'Helped-by:' would be nearer the mark. Thanks! ATB, Ramsay Jones -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v4 4/5] t4205, t6006: Add failing tests for the case when i18n.logOutputEncoding is set
Pretty format string %<(N,[ml]trunc)>%s truncates subject to a given length with an appropriate padding. This works for non-ASCII texts when i18n.logOutputEncoding is UTF-8 only (independently of a printed commit message encoding) but does not work when i18n.logOutputEncoding is NOT UTF-8. There were no breakages as far as were no tests for the case when both a commit message and logOutputEncoding are not UTF-8. Add failing tests for that which will be fixed in the next patch. Signed-off-by: Alexey Shumkin Reviewed-by: Nguyễn Thái Ngọc Duy Reviewed-by: Ramsay Jones --- t/t4205-log-pretty-formats.sh | 140 ++ t/t6006-rev-list-format.sh| 75 +- 2 files changed, 213 insertions(+), 2 deletions(-) diff --git a/t/t4205-log-pretty-formats.sh b/t/t4205-log-pretty-formats.sh index c03a65e..74babce 100755 --- a/t/t4205-log-pretty-formats.sh +++ b/t/t4205-log-pretty-formats.sh @@ -154,6 +154,17 @@ EOF test_cmp expected actual ' +test_expect_success 'left alignment formatting. i18n.logOutputEncoding' ' + git -c i18n.logOutputEncoding=$test_encoding log --pretty="tformat:%<(40)%s" >actual && + qz_to_tab_spaceactual && qz_to_tab_space actual && + qz_to_tab_space actual && cat actual && + cat actual && qz_to_tab_space actual && + qz_to_tab_space actual && qz_to_tab_space actual && + qz_to_tab_space actual && qz_to_tab_space actual && + qz_to_tab_space actual && qz_to_tab_space actual && + qz_to_tab_space actual
