On 7/31/2014 4:52 PM, Matthieu Moy wrote:
> Tanay Abhra writes:
>
>> Signed-off-by: Tanay Abhra
>
> I think I deserve a bit of credit here ;-).
>
Yes, but to show credit would I have to write "from you" or
"signed-off-by"? :)
>> {
>> -return git_config_with_options(fn, data, NULL, 1);
Tanay Abhra writes:
> On 7/31/2014 4:52 PM, Matthieu Moy wrote:
>> Tanay Abhra writes:
>>
>>> Signed-off-by: Tanay Abhra
>>
>> I think I deserve a bit of credit here ;-).
>>
>
> Yes, but to show credit would I have to write "from you" or
> "signed-off-by"? :)
Original-patch-by: would be fine
Matthieu Moy writes:
> Tanay Abhra writes:
>
>> Signed-off-by: Tanay Abhra
>
> I think I deserve a bit of credit here ;-).
>
>> {
>> -return git_config_with_options(fn, data, NULL, 1);
>> +if (git_config_with_options(fn, data, NULL, 1) < 0)
>> +/*
>> + * git_con
Tanay Abhra writes:
> Signed-off-by: Tanay Abhra
I think I deserve a bit of credit here ;-).
> {
> - return git_config_with_options(fn, data, NULL, 1);
> + if (git_config_with_options(fn, data, NULL, 1) < 0)
> + /*
> + * git_config_with_options() normally retu
Currently `git_config()` returns an integer signifying an error code.
During a previous rewrite of the function most of the code was shifted
to `git_config_with_options()`. `git_config_with_options()` normally
returns positive values if its `config_source` parameter is set as NULL,
as most errors a
5 matches
Mail list logo
