Re: [PATCH v6 00/11] Add interpret-trailers builtin
On 04/03/14 19:47, Christian Couder wrote:
> This patch series implements a new command:
>
> git interpret-trailers
>
[snip]
Minor problem: this series causes sparse to complain, thus:
trailer.c:642:6: warning: symbol 'process_trailers' was not \
declared. Should it be static?
The following patch, on top of the 'pu' branch, fixes it:
--- >8 ---
Subject: [PATCH] trailer.c: suppress sparse warning
Check that the public interface, as declared in the trailer.h header
file, is consistent with the actual implementation. Add an #include
of the header file into the implementation file.
Noticed by sparse ("'process_trailers' was not declared. Should it
be static?").
Signed-off-by: Ramsay Jones
---
trailer.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/trailer.c b/trailer.c
index b5de616..95d5874 100644
--- a/trailer.c
+++ b/trailer.c
@@ -1,6 +1,7 @@
#include "cache.h"
#include "run-command.h"
#include "argv-array.h"
+#include "trailer.h"
/*
* Copyright (c) 2013 Christian Couder
*/
--
1.9.0
--- 8< ---
However, for this to work, in addition to squashing the above patch into
your patch #6, you would need to move the creation of the trailer.h header
file from patch 07/11 ("trailer: add interpret-trailers command") to patch
06/11 ("trailer: put all the processing together and print"), where it should
have been anyway! :-D
HTH
ATB,
Ramsay Jones
> Christian Couder (11):
> Add data structures and basic functions for commit trailers
> trailer: process trailers from stdin and arguments
> trailer: read and process config information
> trailer: process command line trailer arguments
> trailer: parse trailers from stdin
> trailer: put all the processing together and print
> trailer: add interpret-trailers command
> trailer: add tests for "git interpret-trailers"
> trailer: execute command from 'trailer..command'
> trailer: add tests for commands in config file
> Documentation: add documentation for 'git interpret-trailers'
>
> .gitignore | 1 +
> Documentation/git-interpret-trailers.txt | 123 ++
> Makefile | 2 +
> builtin.h| 1 +
> builtin/interpret-trailers.c | 33 ++
> git.c| 1 +
> t/t7513-interpret-trailers.sh| 261
> trailer.c| 661
> +++
> trailer.h| 6 +
> 9 files changed, 1089 insertions(+)
> create mode 100644 Documentation/git-interpret-trailers.txt
> create mode 100644 builtin/interpret-trailers.c
> create mode 100755 t/t7513-interpret-trailers.sh
> create mode 100644 trailer.c
> create mode 100644 trailer.h
>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH v6 00/11] Add interpret-trailers builtin
This patch series implements a new command: git interpret-trailers and an infrastructure to process trailers that can be reused, for example in "commit.c". 1) Rationale: This command should help with RFC 822 style headers, called "trailers", that are found at the end of commit messages. (Note that these headers do not follow and are not intended to follow many rules that are in RFC 822. For example they do not follow the line breaking rules, the encoding rules and probably many other rules.) For a long time, these trailers have become a de facto standard way to add helpful information into commit messages. Until now git commit has only supported the well known "Signed-off-by: " trailer, that is used by many projects like the Linux kernel and Git. It is better to implement features for these trailers first in a new command rather than in builtin/commit.c, because this way the prepare-commit-msg and commit-msg hooks can reuse this command. 2) Current state: Currently the usage string of this command is: git interpret-trailers [--trim-empty] [([(=|:)])...] The following features are implemented: - the result is printed on stdout - the [[=]>] arguments are interpreted - a commit message read from stdin is interpreted - the "trailer..key" options in the config are interpreted - the "trailer..where" options are interpreted - the "trailer..ifExist" options are interpreted - the "trailer..ifMissing" options are interpreted - the "trailer..command" config works - $ARG can be used in commands - there are some tests - there is some documentation The following features are planned but not yet implemented: - add more tests related to commands - add examples in documentation - integration with "git commit" Possible improvements: - support GIT_COMMIT_PROTO env variable in commands 3) Changes since version 5, thanks to Junio and Eric: * the --infile option has been removed * many small functions are back to just 'static' instead of 'static inline' * alnum_len() has been adjust to have a "size_t len" parameter and a size_t return value again * strcspn() is used in void parse_trailer() * some test setup commands have been moved in some proper tests * some commit messages have been improved * a patch to setup env variables for commands has been removed * all the memory leaks should have been fixed Christian Couder (11): Add data structures and basic functions for commit trailers trailer: process trailers from stdin and arguments trailer: read and process config information trailer: process command line trailer arguments trailer: parse trailers from stdin trailer: put all the processing together and print trailer: add interpret-trailers command trailer: add tests for "git interpret-trailers" trailer: execute command from 'trailer..command' trailer: add tests for commands in config file Documentation: add documentation for 'git interpret-trailers' .gitignore | 1 + Documentation/git-interpret-trailers.txt | 123 ++ Makefile | 2 + builtin.h| 1 + builtin/interpret-trailers.c | 33 ++ git.c| 1 + t/t7513-interpret-trailers.sh| 261 trailer.c| 661 +++ trailer.h| 6 + 9 files changed, 1089 insertions(+) create mode 100644 Documentation/git-interpret-trailers.txt create mode 100644 builtin/interpret-trailers.c create mode 100755 t/t7513-interpret-trailers.sh create mode 100644 trailer.c create mode 100644 trailer.h -- 1.8.5.2.204.gcfe299d.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
