Re: [PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Brandon Williams
On 12/01, Jeff King wrote: > On Thu, Dec 01, 2016 at 11:54:09AM -0800, Junio C Hamano wrote: > > > > I'm not sure if we should call this "redirect" here. That's how it's > > > used by the curl code, but I think from the perspective of the transport > > > whitelist, it is really "are you overriding

Re: [PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 11:54:09AM -0800, Junio C Hamano wrote: > > I'm not sure if we should call this "redirect" here. That's how it's > > used by the curl code, but I think from the perspective of the transport > > whitelist, it is really "are you overriding the from_user environment". > > > >

Re: [PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 01, 2016 at 11:44:07AM -0800, Brandon Williams wrote: > >> Add a the 'redirect' parameter to 'is_transport_allowed' which allows >> callers to query if a transport protocol can be used on a redirect. > > s/a the/a/ > >> -int is_transport_allowed(const char *type) >

Re: [PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Jeff King
On Thu, Dec 01, 2016 at 11:44:07AM -0800, Brandon Williams wrote: > Add a the 'redirect' parameter to 'is_transport_allowed' which allows > callers to query if a transport protocol can be used on a redirect. s/a the/a/ > -int is_transport_allowed(const char *type) > +int is_transport_allowed(con

Re: [PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Brandon Williams
On 12/01, Brandon Williams wrote: > Add a the 'redirect' parameter to 'is_transport_allowed' which allows > callers to query if a transport protocol can be used on a redirect. > > Signed-off-by: Brandon Williams > --- > http.c | 8 > transport.c | 6 +++--- > transport.h | 7 --

[PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Brandon Williams
Add a the 'redirect' parameter to 'is_transport_allowed' which allows callers to query if a transport protocol can be used on a redirect. Signed-off-by: Brandon Williams --- http.c | 8 transport.c | 6 +++--- transport.h | 7 --- 3 files changed, 11 insertions(+), 10 deletions

[PATCH v6 4/4] transport: check if protocol can be used on a redirect

2016-12-01 Thread Brandon Williams
Add a the 'redirect' parameter to 'is_transport_allowed' which allows callers to query if a transport protocol can be used on a redirect. Signed-off-by: Brandon Williams --- http.c | 8 transport.c | 6 +++--- transport.h | 7 --- 3 files changed, 11 insertions(+), 10 deletions