Re: [PATCH v7 2/2] test-config: Add tests for the config_set API

2014-07-09 Thread Tanay Abhra
On 7/9/2014 5:43 PM, Matthieu Moy wrote: > Tanay Abhra writes: > >> +test_expect_success 'find value with misspelled key' ' >> +test_must_fail check "my.fOo Bar.hi" "Value not found for \"my.fOo >> Bar.hi\"" >> +' > > Sorry, this is still not right. You're checking that either test-config

Re: [PATCH v7 2/2] test-config: Add tests for the config_set API

2014-07-09 Thread Matthieu Moy
Tanay Abhra writes: > +test_expect_success 'find value with misspelled key' ' > + test_must_fail check "my.fOo Bar.hi" "Value not found for \"my.fOo > Bar.hi\"" > +' Sorry, this is still not right. You're checking that either test-config OR test_cmp fails. You want to check both. Basically

[PATCH v7 2/2] test-config: Add tests for the config_set API

2014-07-09 Thread Tanay Abhra
Expose the `config_set` C API as a set of simple commands in order to facilitate testing. Add tests for the `config_set` API as well as for `git_config_get_*()` family for the usual config files. Signed-off-by: Tanay Abhra --- .gitignore| 1 + Makefile | 1 + t/t1308