Re: [PATCHv4 0/4] verify-commit: verify commit signatures

2014-06-27 Thread Jeff King
On Fri, Jun 27, 2014 at 04:13:22PM +0200, Michael J Gruber wrote: > This is v3 rebased on current next (the %G works by Jeff & Junio). Aside from the minor test issues Junio pointed out, I think this version looks OK. > For a general command which allows different verification policies, > I'm st

Re: [PATCHv4 0/4] verify-commit: verify commit signatures

2014-06-27 Thread Jeff King
On Fri, Jun 27, 2014 at 12:07:35PM -0700, Junio C Hamano wrote: > > - Should we do this now or go for generic "git verify" right away? > > I do not think we are ready to do "git verify" yet. If there is one thing that this discussion have convinced me of, it is this. :) -Peff -- To unsubscribe

Re: [PATCHv4 0/4] verify-commit: verify commit signatures

2014-06-27 Thread Junio C Hamano
Michael J Gruber writes: > This is v3 rebased on current next (the %G works by Jeff & Junio). > > Open questions: > > - Should one of git verify-{commit,tag} learn how to verify mergetags? > (Probably no, it differs from both other cases.) If we were to teach one of them, "verify-commit" as part

[PATCHv4 0/4] verify-commit: verify commit signatures

2014-06-27 Thread Michael J Gruber
This is v3 rebased on current next (the %G works by Jeff & Junio). Open questions: - Should one of git verify-{commit,tag} learn how to verify mergetags? (Probably no, it differs from both other cases.) - Should we do this now or go for generic "git verify" right away? That depends on whether si