Re: [RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char

2013-08-29 Thread Matthieu Moy
Jens Lehmann jens.lehm...@web.de writes: But I'm not terribly happy about having the --for-status option in the submodule script in the first place, as I believe it should rather be handled by wt-status.c itself (reading the output of submodule summary using the

[RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char

2013-08-28 Thread Matthieu Moy
Signed-off-by: Matthieu Moy matthieu@imag.fr --- (--for-status was undocumented, so I didn't bother documenting this either) git-submodule.sh | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/git-submodule.sh b/git-submodule.sh index 2979197..ac0fdad

Re: [RFC/PATCH v2 2/3] submodule: introduce --[no-]display-comment-char

2013-08-28 Thread Jens Lehmann
Am 28.08.2013 14:47, schrieb Matthieu Moy: Signed-off-by: Matthieu Moy matthieu@imag.fr --- (--for-status was undocumented, so I didn't bother documenting this either) That's fine, as both if these options will - hopefully - only be used by wt-status.c internally. But I'm not terribly