Re: Making a patch: "git format-patch" does not produce the documented format

2013-08-02 Thread Junio C Hamano
wor...@alum.mit.edu (Dale R. Worley) writes: > I'm preparing some clarifications of SubmittingPatches to explain > things that a new person (e.g., me) would not know. I am not sure if SubmittingPatches is a good place, though. The document is a guidance for people who contribute to _this_ project

Re: Making a patch: "git format-patch" does not produce the documented format

2013-08-02 Thread Dale R. Worley
> From: John Keeping > > git-format-patch(1) says: > > By default, the subject of a single patch is "[PATCH] " followed > by the concatenation of lines from the commit message up to the > first blank line (see the DISCUSSION section of git-commit(1)). > > I think that ac

Re: Making a patch: "git format-patch" does not produce the documented format

2013-07-31 Thread John Keeping
On Wed, Jul 31, 2013 at 05:31:47PM -0400, Dale R. Worley wrote: > Notice that the whole commit message has been formatted as if it is > part of the Subject line, and the line breaks in the commit message > have been refilled. > > The file Documentation/SubmittingPatches says that "git format-patch

Making a patch: "git format-patch" does not produce the documented format

2013-07-31 Thread Dale R. Worley
I'm working on writing a patch, but I'm running into a problem. The patch itself is from this commit: $ git log -1 commit 07a25537909dd277426818a39d9bc4235e755383 Author: Dale Worley Date: Thu Jul 18 18:43:12 2013 -0400 open() returns -1 on failure, and indeed 0 is a p