Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-08 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] 4- Completion choices include their entire path, which is not what bash does by default. For example: cd git/contrib ls completion/git-tab git-completion.bash git-completion.tcsh

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-08 Thread John Keeping
On Tue, Jan 08, 2013 at 06:54:09PM +0100, Manlio Perillo wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] 4- Completion choices include their entire path, which is not what bash does by default. For example: cd git/contrib ls

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-08 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 08/01/2013 19:05, John Keeping ha scritto: [...] After some searching, I found how this is supposed to be done. It is possible to use the -o filenames option to tell Bash completion that the compspec generates filenames, so it can perform any

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-07 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] Below are two suggestions that are in line with this effort but that are not regressions. A) It would be nice if git commit -a TAB also completed with untracked files $ git commit -a foo

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-07 Thread Marc Khouzam
] git-completion.bash: add support for path completion -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] Below are two suggestions that are in line with this effort but that are not regressions. A) It would be nice if git commit

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-05 Thread Marc Khouzam
Junio C Hamano gits...@pobox.com writes: Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? Can you try the attached patch? Thanks for this, it improves the

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-05 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 05/01/2013 21:23, Marc Khouzam ha scritto: [...] I did further testing with your patch and found some less obvious issues. I didn't debug the script myself as I'm not that familiar with it either, but I think the testcases below should help

RE: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Marc Khouzam
-Original Message- From: git-ow...@vger.kernel.org [mailto:git-ow...@vger.kernel.org] On Behalf Of Manlio Perillo Sent: Friday, December 21, 2012 11:55 AM To: git@vger.kernel.org Cc: sze...@ira.uka.de; felipe.contre...@gmail.com; Manlio Perillo Subject: [PATCH v4]

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Junio C Hamano
Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to

Re: [PATCH v4] git-completion.bash: add support for path completion

2013-01-04 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Marc Khouzam marc.khou...@ericsson.com writes: I've been playing with it but I'm not getting the expected behavior when I cd to a sub-directory. Thanks for testing. Manlio? Can you try the attached patch? As I am not familiar with the completion

Re: [PATCH v4] git-completion.bash: add support for path completion

2012-12-21 Thread Junio C Hamano
Manlio Perillo manlio.peri...@gmail.com writes: + case $path in + ?*/*) echo ${path%%/*}/ ;; + *) echo $path ;; $path unquoted??? +# __git_index_files accepts 1 or 2 arguments: +# 1: Options to pass to ls-files (required). +#Supported options are

Re: [PATCH v4] git-completion.bash: add support for path completion

2012-12-21 Thread Manlio Perillo
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 21/12/2012 18:59, Junio C Hamano ha scritto: Manlio Perillo manlio.peri...@gmail.com writes: +case $path in +?*/*) echo ${path%%/*}/ ;; +*) echo $path ;; $path unquoted??? Missed again, thanks. I hope