Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Junio C Hamano
Andreas Schwab writes: > Junio C Hamano writes: > >> I actually think my earlier "it shouldn't be the same (push)" is not >> needed and probably is actively wrong. Just like you can tell >> between >> >> (only one .url) (both .url and .pushurl) >> >> origin there (fe

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Andreas Schwab
Junio C Hamano writes: > I actually think my earlier "it shouldn't be the same (push)" is not > needed and probably is actively wrong. Just like you can tell > between > > (only one .url) (both .url and .pushurl) > > origin there (fetch/push) origin there (f

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Michael J Gruber
Phil Hord venit, vidit, dixit 16.01.2013 17:15: > On Tue, Jan 15, 2013 at 10:53 AM, Junio C Hamano wrote: >> Michael J Gruber writes: >> >>> That being said, I don't mind changing the behaviour of set-url. >> >> I do not think we want to change the behaviour of set-url. > > I agree with Michael

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 16.01.2013 16:50: > Michael J Gruber writes: > >> Junio C Hamano venit, vidit, dixit 15.01.2013 16:53: >> ... >>> * When there are more than one URLs, and there is no pushURL, then >>>show the first URL as (fetch/push), and the remainder in a >>>notatio

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Phil Hord
On Tue, Jan 15, 2013 at 10:53 AM, Junio C Hamano wrote: > Michael J Gruber writes: > >> That being said, I don't mind changing the behaviour of set-url. > > I do not think we want to change the behaviour of set-url. I agree with Michael that changing the set-url behavior would be appropriate her

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Junio C Hamano
Michael J Gruber writes: > Junio C Hamano venit, vidit, dixit 15.01.2013 16:53: > ... >> * When there are more than one URLs, and there is no pushURL, then >>show the first URL as (fetch/push), and the remainder in a >>notation that says it is used only for push, but it shouldn't be >>

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-16 Thread Michael J Gruber
Junio C Hamano venit, vidit, dixit 15.01.2013 16:53: > Michael J Gruber writes: > >> Also there is a conceptual confusion: pushurl is meant to push to the >> same repo using a different url, e.g. something authenticated >> (https/ssh) for push and something faster/easier for fetch. > > That is n

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-15 Thread Junio C Hamano
Michael J Gruber writes: > Also there is a conceptual confusion: pushurl is meant to push to the > same repo using a different url, e.g. something authenticated > (https/ssh) for push and something faster/easier for fetch. That is not necessarily true, depending on the definition of your "same".

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-15 Thread Michael J Gruber
ind changing the behaviour of set-url. > At this point, if you say "set-url --push origin ../third", then > "another" will disappear and gets replaced by "third"; if you > instead say "set-url --add --push origin ../third", then we will see > two (pus

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Junio C Hamano
ush) lines, in addition to one (fetch), making it clear that you are still in (2) above, fetching from and pushing to different places, and having two places to push to. I misread your response From: Jardel Weyrich Subject: Re: [BUG] Possible bug in `remote set-url --add --push` Date:

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Junio C Hamano
Jardel Weyrich writes: > If you allow me, I'd like you to forget about the concepts for a minute, and > focus on the user experience. > Imagine a simple hypothetical scenario in which the user wants to push to 2 > distinct repositories. He already has cloned the repo from the 1st > repository,

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Jardel Weyrich
On 14/01/2013, at 17:09, Junio C Hamano wrote: > Michael J Gruber writes: > >> It seems to me that everything works as designed, and that the man page >> talk about "push URLs" can be read in two ways,... > > Hmph, but I had an impression that Jardel's original report was that > one of the --a

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Junio C Hamano
Michael J Gruber writes: > It seems to me that everything works as designed, and that the man page > talk about "push URLs" can be read in two ways,... Hmph, but I had an impression that Jardel's original report was that one of the --add --pushurl was not adding but was replacing. If that was a

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Jonathan Nieder
Michael J Gruber wrote: > All that "set-url --push --add" does is adding a remote.foo.pushurl > entry to the config. If there was none, there will be one after that. > > If there is no pushurl entry, "push" takes the url entry instead. This > is the "default URL for push", but not a pushurl entry.

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-14 Thread Michael J Gruber
Jardel Weyrich venit, vidit, dixit 12.01.2013 10:33: > On Sat, Jan 12, 2013 at 6:44 AM, Sascha Cunz wrote: >> Am Freitag, 11. Januar 2013, 23:10:36 schrieb Junio C Hamano: >>> Jardel Weyrich writes: I believe `remote set-url --add --push` has a bug. Performed tests with v1.8.0.1 and v1.

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-12 Thread Jardel Weyrich
On Sat, Jan 12, 2013 at 6:44 AM, Sascha Cunz wrote: > Am Freitag, 11. Januar 2013, 23:10:36 schrieb Junio C Hamano: >> Jardel Weyrich writes: >> > I believe `remote set-url --add --push` has a bug. Performed tests >> > with v1.8.0.1 and v1.8.1 (Mac OS X). >> > >> > Quoting the relevant part of th

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-12 Thread Sascha Cunz
Am Freitag, 11. Januar 2013, 23:10:36 schrieb Junio C Hamano: > Jardel Weyrich writes: > > I believe `remote set-url --add --push` has a bug. Performed tests > > with v1.8.0.1 and v1.8.1 (Mac OS X). > > > > Quoting the relevant part of the documentation: > >> set-url > >> > >> Changes URL re

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-12 Thread Junio C Hamano
Jardel Weyrich writes: > Step 1: > > jweyrich@pharao:test_clone1 [* master]$ git remote -v > origin /Volumes/sandbox/test (fetch) > origin /Volumes/sandbox/test (push) > > jweyrich@pharao:test_clone1 [* master]$ git config -l | grep '^remote\.origin' > remote.origin.url=/Volumes/sandbox/test > re

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-12 Thread Jardel Weyrich
Step 1: jweyrich@pharao:test_clone1 [* master]$ git remote -v origin /Volumes/sandbox/test (fetch) origin /Volumes/sandbox/test (push) jweyrich@pharao:test_clone1 [* master]$ git config -l | grep '^remote\.origin' remote.origin.url=/Volumes/sandbox/test remote.origin.fetch=+refs/heads/*:refs/remo

Re: [BUG] Possible bug in `remote set-url --add --push`

2013-01-11 Thread Junio C Hamano
Jardel Weyrich writes: > I believe `remote set-url --add --push` has a bug. Performed tests > with v1.8.0.1 and v1.8.1 (Mac OS X). > > Quoting the relevant part of the documentation: > >> set-url >> Changes URL remote points to. Sets first URL remote points to matching >> regex (first URL i