Re: [BUG] clone: regression in error messages in master

2013-06-22 Thread John Szakmeister
On Fri, Jun 21, 2013 at 1:11 PM, Junio C Hamano wrote: > John Szakmeister writes: [snip] >> I can see where this is confusing, but can also see how it's useful >> information to have. On clone, it's probably not that useful since >> you're looking right at the url, but I could see that informati

Re: [BUG] clone: regression in error messages in master

2013-06-21 Thread Junio C Hamano
John Szakmeister writes: > On Thu, Jun 20, 2013 at 9:16 AM, Ramkumar Ramachandra > wrote: >> Hi, >> >> So this should explain the problem: >> >> # using v1.8.3.1 >> $ git clone https://google.com >> Cloning into 'google.com'... >> fatal: repository 'https://google.com/' not found >> >>

Re: [BUG] clone: regression in error messages in master

2013-06-21 Thread Junio C Hamano
Jeff King writes: > Note that I haven't thought too hard about this; there may be a way to > detect for specific operations that we were expecting more data from the > helper and didn't get it. But even if we do want to go that route, I > think reverting the change to recvline_fh is probably goin

Re: [BUG] clone: regression in error messages in master

2013-06-21 Thread John Szakmeister
On Thu, Jun 20, 2013 at 9:16 AM, Ramkumar Ramachandra wrote: > Hi, > > So this should explain the problem: > > # using v1.8.3.1 > $ git clone https://google.com > Cloning into 'google.com'... > fatal: repository 'https://google.com/' not found > > # using master > $ git clone https://g

Re: [BUG] clone: regression in error messages in master

2013-06-21 Thread Jeff King
On Fri, Jun 21, 2013 at 12:14:33PM +0530, Ramkumar Ramachandra wrote: > Jeff King wrote: > > So I'm not sure if there is a better option than reverting 81d340d4 and > > living with the lesser of two evils (no good message when the helper > > dies silently). > > I dug around, but I still can't jus

Re: [BUG] clone: regression in error messages in master

2013-06-20 Thread Ramkumar Ramachandra
Ramkumar Ramachandra wrote: > diff --git a/transport-helper.c b/transport-helper.c > index 06c08a1..db9bd18 100644 > --- a/transport-helper.c > +++ b/transport-helper.c Oh, and we have to remove test 23 - "proper failure checks for pushing" from t5801-remote-helpers.sh. -- To unsubscribe from this

Re: [BUG] clone: regression in error messages in master

2013-06-20 Thread Ramkumar Ramachandra
Jeff King wrote: > So I'm not sure if there is a better option than reverting 81d340d4 and > living with the lesser of two evils (no good message when the helper > dies silently). I dug around, but I still can't justify that there is no better option. Could you write a commit message for this? -

Re: [BUG] clone: regression in error messages in master

2013-06-20 Thread Jeff King
On Thu, Jun 20, 2013 at 06:46:55PM +0530, Ramkumar Ramachandra wrote: > So this should explain the problem: > > # using v1.8.3.1 > $ git clone https://google.com > Cloning into 'google.com'... > fatal: repository 'https://google.com/' not found > > # using master > $ git clone https: