Submitting patches w/ Thunderbird [was: Re: [PATCH] Add SubmittingPatches]
Johannes Schindelin wrote: Hi, On Mon, 15 Aug 2005, Junio C Hamano wrote: Johannes Schindelin [EMAIL PROTECTED] writes: Maybe we should enhance git-applymbox to detect whitespace corruption in particular, and output the User-Agent header (or if that does not exist, the Message-ID header; thanks, pine) on error. Alternatively, SubmittingPatches could include a big fat CAVEAT, and a note that the submitter might want to send a single SP to herself, save the received mail and check that all is well, prior to sending the first patch. I mean, well, erm, it is sort of, uh, annoying, to send out a corrupt patch *speaksofyourstruly*. Here are some hints on how to successfully submit patches inline using Thunderbird. This recipe appears to work with the current [*1*] Thunderbird from Suse. The following Thunderbird extensions are needed: AboutConfig 0.5 http://aboutconfig.mozdev.org/ External Editor 0.5.4 http://extensionroom.mozdev.org/more-info/exteditor 1) Prepare the patch as a text file using your method of choice. 2) Before opening a compose window, use Edit-Account Settings to uncheck the Compose messages in HTML format setting in the Composition Addressing panel of the account to be used to send the patch. [*2*] 3) In the main Thunderbird window, _before_ you open the compose window for the patch, use Tools-about:config to set the following to the indicated values: mailnews.send_plaintext_flowed = false mailnews.wraplength = 999 4) Open a compose window and click the external editor icon. 5) In the external editor window, read in the patch file and exit the editor normally. 6) Back in the compose window: Add whatever other text you wish to the message, complete the addressing and subject fields, and press send. 7) Optionally, undo the about:config/account settings changes made in steps 2 3. [Footnotes] *1* Version 1.0 (20041207) from the MozillaThunderbird-1.0-5 rpm of Suse 9.3 professional updates. *2* It may be possible to do this with about:config and the following settings but I haven't tried, yet. mail.html_compose = false mail.identity.default.compose_html = false mail.identity.id?.compose_html = false - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Hi, On Sat, 13 Aug 2005, Junio C Hamano wrote: +Note that your maintainer does not subscribe to the git mailing +list (he reads it via mail-to-news gateway). Wow. I didn't even read a newsgroup in decades... BTW, I don't know how many people still use pine, but for those poor souls it may be good to mention that the quell-flowed-text is needed for recent versions. Ciao, Dscho - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Johannes Schindelin [EMAIL PROTECTED] writes: BTW, I don't know how many people still use pine, but for those poor souls it may be good to mention that the quell-flowed-text is needed for recent versions. Contributions from pine users are very much appreciated. Among the patches I either receive or pick up from the list, 15-20% have WS corruption one way or another, which is starting to annoy me. What annoys me more are MIME quoted printable, though, but that is partly my fault. I haven't counted what percentage of those WS corrupted ones are from Pine, so please do not take the above 15-20% number to have anything to do with Pine. - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
On Tue, 16 Aug 2005, Johannes Schindelin wrote:
BTW, I don't know how many people still use pine, but for those poor souls
it may be good to mention that the quell-flowed-text is needed for recent
versions.
And 4.58 needs at least this
Linus
---
diff-tree 8326dd8350be64ac7fc805f6563a1d61ad10d32c (from
e886a61f76edf5410573e92e38ce22974f9c40f1)
Author: Linus Torvalds [EMAIL PROTECTED]
Date: Mon Aug 15 17:23:51 2005 -0700
Fix pine whitespace-corruption bug
There's no excuse for unconditionally removing whitespace from
the pico buffers on close.
diff --git a/pico/pico.c b/pico/pico.c
--- a/pico/pico.c
+++ b/pico/pico.c
@@ -219,7 +219,9 @@ PICO *pm;
switch(pico_all_done){ /* prepare for/handle final events */
case COMP_EXIT : /* already confirmed */
packheader();
+#if 0
stripwhitespace();
+#endif
c |= COMP_EXIT;
break;
-
To unsubscribe from this list: send the line unsubscribe git in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Linus Torvalds [EMAIL PROTECTED] writes: And 4.58 needs at least this diff-tree 8326dd8350be64ac7fc805f6563a1d61ad10d32c (from e886a61f76edf5410573e92e38ce22974f9c40f1) Author: Linus Torvalds [EMAIL PROTECTED] Date: Mon Aug 15 17:23:51 2005 -0700 Fix pine whitespace-corruption bug There's no excuse for unconditionally removing whitespace from the pico buffers on close. Wow. This is a _terrible_ one. Isn't pico code also supposed to be a standalone editor of some sort? I wonder how anybody could tolerate this kind of dictatorship ;-). At least the changelog entry seems to say that 4.60 removed this feature. - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Hi, On Mon, 15 Aug 2005, Linus Torvalds wrote: On Tue, 16 Aug 2005, Johannes Schindelin wrote: BTW, I don't know how many people still use pine, but for those poor souls it may be good to mention that the quell-flowed-text is needed for recent versions. And 4.58 needs at least this [...] Sorry, I forgot the no-strip-whitespace-before-send option, too. AFAIK it was introduced in 4.60 (the fix Junio was referring to). Maybe we should enhance git-applymbox to detect whitespace corruption in particular, and output the User-Agent header (or if that does not exist, the Message-ID header; thanks, pine) on error. Ciao, Dscho - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Johannes Schindelin [EMAIL PROTECTED] writes: Maybe we should enhance git-applymbox to detect whitespace corruption in particular, and output the User-Agent header (or if that does not exist, the Message-ID header; thanks, pine) on error. We _could_ but I doubt it would help anybody. The damage is already done. - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
Hi, On Mon, 15 Aug 2005, Junio C Hamano wrote: Johannes Schindelin [EMAIL PROTECTED] writes: Maybe we should enhance git-applymbox to detect whitespace corruption in particular, and output the User-Agent header (or if that does not exist, the Message-ID header; thanks, pine) on error. Alternatively, SubmittingPatches could include a big fat CAVEAT, and a note that the submitter might want to send a single SP to herself, save the received mail and check that all is well, prior to sending the first patch. I mean, well, erm, it is sort of, uh, annoying, to send out a corrupt patch *speaksofyourstruly*. Ciao, Dscho - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH] Add SubmittingPatches
On Tue, Aug 16, 2005 at 03:41:04AM +0200, Johannes Schindelin wrote: On Mon, 15 Aug 2005, Junio C Hamano wrote: Johannes Schindelin [EMAIL PROTECTED] writes: Maybe we should enhance git-applymbox to detect whitespace corruption in particular, and output the User-Agent header (or if that does not exist, the Message-ID header; thanks, pine) on error. Alternatively, SubmittingPatches could include a big fat CAVEAT, and a note that the submitter might want to send a single SP to herself, save the received mail and check that all is well, prior to sending the first patch. I mean, well, erm, it is sort of, uh, annoying, to send out a corrupt patch *speaksofyourstruly*. If you have some trouble sending them out, you can use git format-patch --mbox and git send-email which seems to consistently do the right thing. -- Ryan Anderson sometimes Pug Majere - To unsubscribe from this list: send the line unsubscribe git in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
