Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Junio C Hamano
Elia Pinto writes: > I have no problems rerolling this simple patch, but i need to know > what is the (git) right style in this case. If I were doing this... diff --git a/contrib/subtree/t/t7900-subtree.sh b/contrib/subtree/t/t7900-subtree.sh index 66ce4b0..c1d0b23 100755 --- a/contrib/subtre

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread David Kastrup
Johannes Sixt writes: > Am 5/22/2014 15:19, schrieb David Kastrup: >> Torsten Bögershausen writes: >> >>> On 2014-05-22 14.48, Elia Pinto wrote: Found by check-non-portable-shell.pl >>> >>> Thanks for picking this up -export TEST_DIRECTORY=$(pwd)/../../../t +TEST_DIRECTORY=$(pwd)

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Johannes Sixt
Am 5/22/2014 15:19, schrieb David Kastrup: > Torsten Bögershausen writes: > >> On 2014-05-22 14.48, Elia Pinto wrote: >>> Found by check-non-portable-shell.pl >> >> Thanks for picking this up >>> -export TEST_DIRECTORY=$(pwd)/../../../t >>> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTO

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Elia Pinto
5-22 14.48, Elia Pinto wrote: >> Found by check-non-portable-shell.pl > > Thanks for picking this up >> -export TEST_DIRECTORY=$(pwd)/../../../t >> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY > Minor remark: > Both commands should go on their own line, like this: > > TEST_DIRECTORY=$

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread David Kastrup
Torsten Bögershausen writes: > On 2014-05-22 14.48, Elia Pinto wrote: >> Found by check-non-portable-shell.pl > > Thanks for picking this up >> -export TEST_DIRECTORY=$(pwd)/../../../t >> +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY > Minor remark: > Both commands should go on their

Re: [PATCH] Get rid of the non portable shell export VAR=VALUE costruct

2014-05-22 Thread Torsten Bögershausen
On 2014-05-22 14.48, Elia Pinto wrote: > Found by check-non-portable-shell.pl Thanks for picking this up > -export TEST_DIRECTORY=$(pwd)/../../../t > +TEST_DIRECTORY=$(pwd)/../../../t && export TEST_DIRECTORY Minor remark: Both commands should go on their own line, like this: TEST_DIRECTORY=$(pwd